If no executable ThinLinc profiles are found, users entering the profile chooser are met with an error message. This error message was improved upon in bug 5499 to better point the user in the right direction, which typically means installing a desktop environment. However, the profile chooser could be even more specific regarding missing installed X11 desktops. It would be great if the profile chooser distinguished between and conveyed information concerning X11 and Wayland desktops. Since X11 desktop environments are shipped less and less by default nowadays, this information can likely be key for struggling users.
Fortunately, bug 8588 introduced an API which facilitates discerning installed X11 and/or Wayland desktop environments.
> MUST: > * The error page must be more specific to what extent proper desktop environments are missing ✅ The error page now informs the user (1) if no desktops at all are installed, or (2) if only Wayland type desktops are installed, or (3) if there are some X11 type desktops installed after all. > SHOULD: > * It should be clear to end users that this information primarily targets sysadmins ✅ The beginning of the error message states clearly that one should contact a sysadmin for this problem. > * Technical information targeting sysadmins should not be visible by default ❌ All information is visible.
There are a few issues with the API, see code review comments. Reopening.
(In reply to Samuel Mannehed from comment #6) > There are a few issues with the API, see code review comments. Reopening. The API concerns have been addressed. In addition, the scenario with installed X11 desktops has been complemented with how to possibly proceed next, and only a subset of potentially many desktops will now be written.
Looks good! I tested build 4080 on Ubuntu 24.04: ✓ All still good when there are available profiles ✓ Helpful error when a desktop is installed, it matches a profile, but the profile is disabled (not in order) ✓ Helpful error when only a Wayland desktop is installed ✓ Helpful error when a desktop is installed, but doesn't match any profile ✓ Helpful error when no desktop is installed Commits and release notes look good. > MUST: > * The error page must be more specific to what extent proper desktop environments are missing Yes! > SHOULD: > * It should be clear to end users that this information primarily targets sysadmins Somewhat, the text recommends contacting the sysadmin. > * Technical information targeting sysadmins should not be visible by default Not implemented, see bug 8593.
