Bug 8594 - Desktop lists in tl-setup and profile chooser are arbitrarily sorted
Summary: Desktop lists in tl-setup and profile chooser are arbitrarily sorted
Status: RESOLVED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.19.0
Assignee: Hannes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-26 11:35 CEST by Tobias
Modified: 2025-06-02 13:59 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:
MUST * The user must be shown a complete list of desktops found SHOULD COULD * The list shown could, if applicable, show the desktops with an existing but misconfigured profile at the top.

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tobias cendio 2025-05-26 11:35:52 CEST 
In the case of no identified executable ThinLinc profiles, a list of X11 desktop environments installed on the system are displayed as additional information for the user to work with -- introduced in bug 8590 and bug 8587 for the profile chooser and tl-setup, respectively.

This list is truncated at just a few desktops however, so as not to elongate the pages too much, and it's hinted that there are additional desktops not included in the list.

It shouldn't be on our end to sort this list, primarily since we cannot hope to make proper sorting decisions here. Thus it is in a sense arbitrary what few desktops are included in the list.

The user might get the impression that these are the most compatible desktops chosen by ThinLinc. Moreover, if only session files in say /etc/X11/sessions/ happen to be shown, the user might not be aware of session files in /usr/share/xsessions/, and choose a less desirable path forward.
Comment 1 Tobias cendio 2025-05-26 11:37:21 CEST 
A scrollable paragraph in the likes of the EULA tl-setup page could perhaps be a fitting solution, at least for the graphical case.
Comment 4 Hannes cendio 2025-06-02 13:59:43 CEST 
> MUST
> * The user must be shown a complete list of desktops found
Yes, the output no longer only shows the first five and is instead presented in a scrollable list.
> SHOULD

> COULD
> * The list shown could, if applicable, show the desktops 
>   with an existing but misconfigured profile at the top.
This was addressed in bug 8596
Note You need to log in before you can comment on or make changes to this bug.