Bug 8587 - tl-setup doesn't inform about missing desktop enviroments
Summary: tl-setup doesn't inform about missing desktop enviroments
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.19.0
Assignee: Hannes
URL:
Keywords: frifl_tester, relnotes, samuel_tester
Depends on:
Blocks:
 
Reported: 2025-05-14 11:37 CEST by Hannes
Modified: 2025-05-27 11:04 CEST (History)
3 users (show)

See Also:
Acceptance Criteria:
MUST * The user must be warned about missing profiles when installing a thinlinc server. SHOULD * The user should be presented possible solutions in tl-setup. COULD * The user could get specific information about found profiles.


Attachments
Screenshot of the profile error page in tl-setup (35.74 KB, image/png)
2025-05-27 10:58 CEST, Samuel Mannehed
Details

Description Hannes cendio 2025-05-14 11:37:14 CEST
Currently, the user only gets information about missing executable profiles at the profile chooser. It would be wise to inform of this during tl-setup. This should enable sysadmins to take immediate action when setting up a system.
Comment 1 Alexander Zeijlon cendio 2025-05-15 16:02:05 CEST
We can use the same mechanism that we use in the profile chooser during session start to verify if there will be profiles available.

It might be that we can provide admins with "smarter" information in the future. But for now, it should be enough to see this more as an opportunity to notify them that there will be an issue regarding profiles.
Comment 2 Alexander Zeijlon cendio 2025-05-15 16:12:58 CEST
Similar to how a few other pages in tl-setup work, this new profile check page will be as non-intrusive as possible.

This means that when running the GTK-installer, we will only show the page if ThinLinc was unable to find any executable profiles.

For the text installer, the profile check section will only be printed if ThinLinc was unable to find any executable profiles.
Comment 5 Alexander Zeijlon cendio 2025-05-16 09:18:26 CEST
Tested running tl-setup both in GUI and fall-back text mode, with and without profiles available.

Everything seems to work as expected, the page is only shown when there are no profiles found.

Also tested running with an answers-file. tl-setup runs without pausing at the profile section. This is expected and is consistent with, for example, the section that warns about sudo PATH.

> MUST
> * The user must be warned about missing profiles when installing a thinlinc
>   server.
Users are now warned.

> SHOULD
> * The user should be presented possible solutions in tl-setup.
We are showing a link to our platform-specific note about missing profiles.

> COULD
> * The user could get specific information about found profiles.
We are leaving this out for now. There is no mechanism in the profile checker function to determine why profiles could not be found. Users should still get a lot of value just from being notified that there will be an issue during system setup.
Comment 24 Hannes cendio 2025-05-21 16:27:42 CEST
Resolving again after feedback by mail.
Comment 27 Samuel Mannehed cendio 2025-05-27 10:58:20 CEST
Created attachment 1272 [details]
Screenshot of the profile error page in tl-setup
Comment 28 Samuel Mannehed cendio 2025-05-27 11:04:49 CEST
Looks good! I tested tl-setup both text mode and gui-mode on Ubuntu 24.04 using build 4079:

 ✓ Page doesn't appear when one profile is available
 ✓ Page appears when a desktop is installed, it matches a profile, but the profile is disabled (not in order)
 ✓ Page appears when a desktop is installed, but doesn't match any profile
 ✓ Page appears when no desktop is installed

I think the error text is good, and the GUI page looks mostly good. There is a slight wrapping error, see attachment 1272 [details], but this will be reworked in bug 8592.

The documentation is now much more helpful and the release notes are good. I also looked through the commits, no complaints there.

> MUST
> * The user must be warned about missing profiles when installing a thinlinc server.
Yep!

> SHOULD
> * The user should be presented possible solutions in tl-setup.
Yep!

> COULD
> * The user could get specific information about found profiles.
Will be handled in other bugs.

Note You need to log in before you can comment on or make changes to this bug.