Bug 8588 - Profile detection returns insufficient information
Summary: Profile detection returns insufficient information
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.19.0
Assignee: Tobias
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks:
 
Reported: 2025-05-14 15:03 CEST by Tobias
Modified: 2025-05-26 10:10 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:
MUST: • Be able to determine if there are X11 desktops installed on the system • Be able to determine if there are Wayland desktops installed on the system • Be able to determine if installed X11 desktops has configured ThinLinc profiles


Attachments

Description Tobias cendio 2025-05-14 15:03:48 CEST
It is of interest for some ThinLinc modules that information returned from profile detection is more elaborate than the fact that profiles are found or not.

This could for instance be used in the profile chooser to improve end user feedback when no profiles are found.
Comment 1 Tobias cendio 2025-05-19 12:16:45 CEST
(In reply to Tobias from comment #0)

Expanding this problem framing a bit:

Users may encounter a situation where there are no available profiles on the system, which commonly stems from the lack of installed desktop environments. In order to guide them towards a solution to this problem, the reason behind must be better specified by ThinLinc.

This additional information is useful e.g. during the setup process (see bug 8587) which solely affects sysadmins, but also during the session startup process in particular when selecting profiles, which may affect all types of users.

For this purpose, we’d like to have modularized tools in place that can be independently accessed by various modules and provide more information as to why no profiles are available.

As a starting point, we’d like to distinguish between installed X11 and Wayland desktops on the system, or the lack thereof. In addition, if X11 desktops are indeed identified on the system, we should be able to determine if ThinLinc lacks a corresponding configured profile.
Comment 4 Tobias cendio 2025-05-20 15:14:22 CEST
Public APIs has been added in the profiles module available for other modules, able to determine if there are X11 or Wayland desktops installed on the system, and additionally if any installed X11 desktops match any configured ThinLinc profiles or not.

> MUST:
> • Be able to determine if there are X11 desktops installed on the system
✅ Check.
> • Be able to determine if there are Wayland desktops installed on the system
✅ Check.
> • Be able to determine if installed X11 desktops has configured ThinLinc profiles
✅ Check.
Comment 5 Samuel Mannehed cendio 2025-05-21 16:15:00 CEST
Looks mostly good. I do have some questions about "find_matching_profiles", however. See the code-review. Reopening until I get some clarification.
Comment 8 Hannes cendio 2025-05-22 12:27:17 CEST
Resolving again after fixing feedback by mail.
Comment 10 Samuel Mannehed cendio 2025-05-23 14:53:45 CEST
Nice! Code and tests look good.

Note You need to log in before you can comment on or make changes to this bug.