Our last vendor drop was 2021-11-17, so a lot has happened since the. We should sync up.
I've looked through the release notes, and pull requests of noVNC (1.3.0, 1.4.0 and 1.5.0) until master as of 2025-01-07, and the main items that are relevant for us are: 1. Added basic support for keeping lock keys in sync with the server - https://github.com/novnc/noVNC/pull/1795 - bug 7259 - needs testing (and perhaps documentation) 2. Resizes of the viewport are handled in a more modern way. This allows our library to not only react to browser window changes, but to size changes of the screen element as well. - https://github.com/novnc/noVNC/pull/1365 - https://github.com/novnc/noVNC/pull/1617 - https://github.com/novnc/noVNC/issues/1903 - https://github.com/novnc/noVNC/pull/1735 - needs testing 3. Keyboard bug fixes - https://github.com/novnc/noVNC/pull/1881 - https://github.com/novnc/noVNC/pull/1698 - test & submit new bugs in our bugzilla 4. Clipboard fix - https://github.com/novnc/noVNC/pull/1845 - test & submit new bug in our bugzilla 5. Don't crash if we can't use localStorage - https://github.com/novnc/noVNC/pull/1710 - bug 8014 - needs testing 6. Refactoring & code cleanups - https://github.com/novnc/noVNC/pull/1428 - https://github.com/novnc/noVNC/pull/1677 - https://github.com/novnc/noVNC/pull/1739 - https://github.com/novnc/noVNC/pull/1782 - needs testing Aside from the above, things could have been committed without a mentioned in release notes or as part of a pull request. We need to look through the full list of commits since the last vendordrop. The main goal is to look for things that are fixed as part of the new vendordrop so that we can mention them in ThinLinc's release notes.
When updating TigerVNC (bug 8485), we will get support for back/forward mouse buttons in the VNC server. Thus, before doing a vendordrop of noVNC, we want to make sure the upstream code is prepared for this feature. In practice, this means the two following pull requests needs to be completed and merged: https://github.com/novnc/noVNC/pull/1919 https://github.com/novnc/noVNC/pull/1921
(In reply to Samuel Mannehed from comment #1) > 2. Resizes of the viewport are handled in a more modern way. This allows our > library to not only react to browser window changes, but to size changes > of > the screen element as well. > - https://github.com/novnc/noVNC/pull/1365 > - https://github.com/novnc/noVNC/pull/1617 > - https://github.com/novnc/noVNC/issues/1903 > - https://github.com/novnc/noVNC/pull/1735 > - needs testing Bug 7992 looks to be fixed as a result of https://github.com/novnc/noVNC/pull/1735.
Looked through all commits on master since the last vendor drop (2021-11-17) and sorted out all commits not connected to an issue. Then I removed all commits that were only tests, styling and translations. I also removed all commits that we already have in ThinLinc. For the remaining, I tried to determine if the change was substantial enough that it should be mentioned in the release notes. I could not find any commit from this list that wasn't minor fixes nor relevant to ThinLinc. Some testing is still needed, and this should probably be done by creating a big diff and finding relevant areas to test.
