Created attachment 1101 [details] Firefox with always show scrollbar and resizing error. When resizing the textarea with speed, it throws out this error message and lock the session. To reproduce this error message: 1. Languagetool extension enable, and Firefox settings turn on Always show scrollbars. 2. Go to clipboard and focus on the textarea 3. Resize the textarea fast.
This has been spotted on Windows without the Firefox settings, and this because it already has the "always show scrollbars". The same issue have can be reproduced in chrome and edge browsers, but it's lot harder to reproduce. Here is a thread on resize-observer GitHub. https://github.com/juggle/resize-observer/issues/103
Created attachment 1102 [details] chrome error message
After commmit r39902, for bug 7909, this can no longer be reproduced. That commit added a 0.2s transition to all properties of textareas. This seems to prevent the crash.
To test this, I did the following: 1. Enabled “Always show scrollbars” in Firefox settings 2. Opened Language Tool extension settings and enabled LT for private tabs 3. Opened Web Access and connected in a new private tab 4. Opened the inspector for the clipboard textarea and disabled the transition-property 5. Got the crash If I then either disabled LT or re-enabled the transition-property, I could no longer get the crash. Note that Web Admin doesn't crash or log anything regarding such issues when doing the above procedure regarding any of the Web Admin textareas. But since the crash was related to LT, and no longer occurs in the current state of things, I see no reason to keep this around.
Tested this as described in comment #4. I get the crash when the transition is turned off, and I did not manage to get the crash with the transition in place. So, I consider this fixed.
Tested this again, and now I get the crash even with the changes mentioned in comment #3. I am not sure what I did differently this time, but I found one thing that I did now that I'm not sure if I did before. This is to click in the text area to activate LanguageTool before resizing it. I also found that resizing vertically will trigger the crash more often for some reason.
The ResizeObserver mentioned in the error message is not ours. The only ResizeObserver we create in our code is for the framebuffer window. So, I would say that this bug is not about fixing the error, but rather about handling the error better and not freezing the session.
There is a workaround in place in noVNC, at least for firefox. https://github.com/novnc/noVNC/commit/2f602da96145f02b7765916ac8abfb5022097c29 In edge and chrome you get this instead: > ResizeObserver loop limit exceeded Since this only appears to happen when languagetool is active, I reported an issue to them. We have to see what happens with this. https://github.com/languagetool-org/languagetool/issues/8218
Note that the change that made this more difficult to reproduce (part of r39902) was reverted in r40079.
