The poppler we include in the ThinLinc client for thinlinc is rather old. We last updated it in 2017. We should update to a current version to get upstream fixes.
This is needed to resolve bug 8361 since the current version doesn't compile with modern gcc.
Poppler has switched to CMake now, which we haven't used normally in the ThinLinc build before (TigerVNC uses CMake, but heavily modified for us). We need to come up with some new methods to build everything correctly there.
Apparently, we have a bit of a dependency loop with bug 8361. The old poppler doesn't compile with a new gcc, but the new poppler doesn't compile with an old gcc (because it wants better C++ and C versions). Let's see if we can patch something to work.
The current version of Poppler makes heavy use of new C++ features. It doesn't look feasible to adjust that. The latest release that still uses C++11 is poppler 21.11.0. It still uses std::mutex, though, which is broken for Windows (bug 8419). It seems like I can revert that, though, and get it to build. I can even get 21.12.0 running that way. Let's see that this version of poppler still works with an updated gcc.
Seems to work, so let's go ahead with that intermediate version of poppler.
Did test prints on Fedora 42 and Windows 11, and the prints look the same as before, with one exception; the alpha/background issue on Linux seems to be resolved (mentioned in bug 5347).
Tested client build 3920 on Windows 10, macOS 15 and Fedora 41. Printed some of our test pdfs, could not see any issues. Also tested bug 7455. Commits look good, closing.
