Bug 7918 - Client should follow new visual profile
Summary: Client should follow new visual profile
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Pierre Ossman
URL:
Keywords: relnotes, samuel_tester
: 7959 (view as bug list)
Depends on:
Blocks: 7903
  Show dependency treegraph
 
Reported: 2022-05-05 10:26 CEST by Pierre Ossman
Modified: 2022-10-12 11:22 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:
* Client should follow the new visual profile * Client should use the same colors as most other applications on the different platforms


Attachments

Description Pierre Ossman cendio 2022-05-05 10:26:34 CEST
We have a new visual profile that should be followed in the ThinLinc Client interface.
Comment 1 Pierre Ossman cendio 2022-05-05 10:27:32 CEST
Note that it seems Windows has some caching of icons. When installing a client with the new logo, the launcher on the task bar still retains the old icon.

Perhaps we can call something in the installer that flushes this cache?
Comment 2 William Sjöblom cendio 2022-07-04 12:55:02 CEST
*** Bug 7959 has been marked as a duplicate of this bug. ***
Comment 6 Pierre Ossman cendio 2022-07-15 08:26:45 CEST
(In reply to Pierre Ossman from comment #1)
> Note that it seems Windows has some caching of icons. When installing a
> client with the new logo, the launcher on the task bar still retains the old
> icon.
> 
> Perhaps we can call something in the installer that flushes this cache?

I found this:

> Applications that register new handlers of any type must call SHChangeNotify
> with the SHCNE_ASSOCCHANGED flag to instruct the Shell to invalidate the icon
> and thumbnail cache. This will also load new icon and thumbnail handlers that
> have been registered. Note, however, that icon overlay handlers are not
> reloaded.

https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shchangenotify

However, we already call this function from the installer. So something isn't working. We do have this note, though:

> ; Refresh the shell. Note: MSDN says that SHCNF_IDLIST must be specified,
> but the NSIS example does not. 

That comment isn't true any more, as NSIS has updated their example:

https://nsis.sourceforge.io/Refresh_shell_icons
Comment 7 Pierre Ossman cendio 2022-07-15 09:42:15 CEST
Hmm... Odd. I can't reproduce this on the Windows 10 laptop. But I can reproduce it on the Windows 10 desktop in the lab.

One theory is that this has to do with a 32-/64-bit mismatch. Our installer is always 32-bit, and the laptop is 32-bit, whilst the desktop is 64-bit.
Comment 8 Pierre Ossman cendio 2022-07-15 14:07:45 CEST
Icon cache issue moved to bug 7970.

Everything here should now be good enough for a basic version.
Comment 9 Samuel Mannehed cendio 2022-08-02 11:35:16 CEST
I have verified the following:

 ✓ New GUI background colors look more modern
 ✓ New top banner in login window looks nice

 ✓ GNOME 42 (Fedora 36):
   ✓ New icon when opening the RPM in GNOME Software
   ✓ New icon in GNOME activities
   ✓ New symbolic icon in GNOME top bar
   ✓ New GUI background colors fit nicely with GNOME *

 ✓ Windows 11:
   ✗ the installer needs more work; see bug 7960
   ✓ New icon on the desktop
   ✓ New icon in the start menu
   ✓ New icon in taskbar
   ✓ New GUI background colors fit nicely with Windows GUI **

 ✓ macOS 12.4:
   ✗ "installer" needs an update; see bug 7976
   ✓ New icon on the desktop
   ✓ New icon in the dock and in spotlight
   ✓ New icon in the top menu bar
   ✓ New GUI background colors fit nicely with macOS ***

* The new colors (#F6F5F4) are not as white as the background in GNOME settings (#FAFAFA), but this is the same as we used in tl-setup and the profile chooser. Our new color fits well in older GNOME environments.

** Our client now uses #F3F3F3, and it's difficult to make it fit well on Windows since most areas change depending on your theme. I could find areas that use #FBFBFD, these combined with the themed colored tints make our client fit nicely in my eyes despite the differences.

*** Our client now uses #F6F6F6 on macOS, and from what I could see, the macOS settings use a very slight gradient between #F3F0F3 and #F4F1F4. The colors we use don't look out of place.

Note You need to log in before you can comment on or make changes to this bug.