Bug 7976 - macOS "installer image" should follow new visual profile
Summary: macOS "installer image" should follow new visual profile
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client platforms (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Linn
Keywords: frifl_tester, relnotes, tobfa_tester
Depends on:
Blocks: 7903
  Show dependency treegraph
Reported: 2022-08-02 11:06 CEST by Samuel Mannehed
Modified: 2023-08-08 18:38 CEST (History)
3 users (show)

See Also:
Acceptance Criteria:

Screenshot illustrating the problem (762.36 KB, image/png)
2023-07-14 17:24 CEST, Samuel Mannehed
Screenshot after the fix (557.26 KB, image/png)
2023-08-04 17:41 CEST, Samuel Mannehed

Description Samuel Mannehed cendio 2022-08-02 11:06:20 CEST
We have a new visual profile that should be followed in the ThinLinc Client "installer image" for macOS.
Comment 1 Samuel Mannehed cendio 2022-08-09 14:45:32 CEST
When looking at generating a new background image for this purpose, we stumbled upon what looks like a bug with ImageMagick or librsvg in cenbuild, see bug 7977 for this.

As a workaround we can use ImageMagick locally in the meanwhile.
Comment 13 Linn cendio 2022-08-15 11:37:15 CEST
Tested on macOS 12.5, and the window size and the background image have changed to the updated ones. It is also still possible to install the client as before.
Comment 14 Frida Flodin cendio 2022-08-15 16:24:13 CEST
Tested on macOS 12.5 and compared to the old client.

- The new visual profile is used and looks good.
- The layout is improved, and the text is more clear.
- The image and the installed client works as expected.
Comment 15 Linn cendio 2022-08-15 16:52:58 CEST
Checked the client on HiDPI and compared it to the Firefox installer - ours looks quite unsharp. The background image for Firefox has 144 DPI and our image has 72 DPI. It should be possible to generate a sharper image through ImageMagick.
Comment 17 Linn cendio 2022-08-19 10:34:19 CEST
While the design of the new installer background is finished, the issue with getting the window to the correct size proves to be more complex than initially thought. This will be worked on in bug 5204, and this bug is basically just waiting for that one to be finished in order to be ready for testing.

Note for tester if relevant:
Check if the macOS portion of bug 7226 has been finished, otherwise this can be included in the testing of this bug.
Comment 18 Samuel Mannehed cendio 2022-08-19 17:03:59 CEST
The nightly macOS client build from jenkins has the incorrect finder window size. It seems a new DS_STORE file wasn't committed along with the layout changes of the background image in r38743.
Comment 21 Linn cendio 2022-08-25 08:43:32 CEST
The window size has now been fixed in bug 5204, and instructions for manually generating a DS_Store file have been updated. This bug is now ready for testing.

Also, note that in bug 7984, we found a way to do some modifications to an existing DS_Store file via a Perl module. In the future, this is probably the preferable way to do simple DS_Store updates.
Comment 22 Tobias cendio 2022-08-25 15:01:39 CEST
Tested client builds #2663 and #2682 on macOS 12.5.1.

The updated graphical style is in line with the new visual profile: new icon, sparse text layout, white background combined with blue bar. In addition, the installer window displays proper dimensions, with everything relevant showing as intended.ยจ

Comment 25 Samuel Mannehed cendio 2023-07-14 17:24:38 CEST
Created attachment 1133 [details]
Screenshot illustrating the problem

After applying our new visual profile to more parts of our product we have ended up using slightly different "blue lines". In particular, the blue line graphic looks too high compared to other components.

The blue graphic at the bottom of the new "installer" background is in absolute numbers approximately the same as the maximum height of the blue line in Web Access and Web Admin. But since the total size of the area it appears in (the installer folder window) is smaller, the proportions are off. We should reduce the height of this blue line.
Comment 28 Samuel Mannehed cendio 2023-08-04 17:41:23 CEST
Created attachment 1146 [details]
Screenshot after the fix
Comment 29 Samuel Mannehed cendio 2023-08-04 17:41:36 CEST
This has been fixed now, the blue line in the macOS "installer" background is now 14px (3.7% of the visible height).

It looks much more in line with the rest of the product now.
Comment 30 Samuel Mannehed cendio 2023-08-04 17:57:25 CEST
I tested the new background (as seen in the attached screenshot) on macOS 13.1.
Comment 31 Frida Flodin cendio 2023-08-08 15:52:44 CEST
I can verify this fix. The "installer" looks much better and more in line with the rest of the product.

Note You need to log in before you can comment on or make changes to this bug.