Bug 5909 - String for custom compression level is different in tlclient and vncviewer
Summary: String for custom compression level is different in tlclient and vncviewer
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.12.0
Assignee: Samuel Mannehed
Keywords: prosaic
Depends on: 7373
  Show dependency treegraph
Reported: 2016-05-25 16:16 CEST by Peter Åstrand
Modified: 2022-09-08 09:15 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Peter Åstrand cendio 2016-05-25 16:16:14 CEST
In tlclient, we are using the string:

"level (1=fast, 6=best)"

in vncviewer, we are using:

"level (1=fast, 6=best [4-6 are rarely useful])"

We have translations for both, but with Russian active, the result is too long and does not fit in the window (even after fixing bug 5908).

IOW, there are in principle two problems, but the solution might be the same: I think we should consider changing to the short version, even upstream.
Comment 1 Pierre Ossman cendio 2016-05-31 10:33:25 CEST
I don't think 1-6 is the actual range here so we might want to have a look at that as well.
Comment 3 Karl Mikaelsson cendio 2018-01-29 11:00:31 CET
In a recent support issue, we got a report that the 1 setting is also "rarely useful" as it apparently forces full-screen updates. This isn't "fast" as described by the label. The useful range of this parameter is thus 2-3 and we're considering telling users *less* about what the useful range is (this bug) and *expanding* the range to 9? (bug 7106)?

Reassigning to '---' for discussion.
Comment 4 Pierre Ossman cendio 2018-01-30 13:22:27 CET
This bug will be just to get the strings in sync. We'll handle the confusion about the range and what it means on bug 7106.
Comment 5 Samuel Mannehed cendio 2019-12-20 15:35:29 CET
The upstream vncviewer description has been updated in these two commmits:


We need to do a vendordrop of TigerVNC to get this fix. We also need to update the screenshot of the client options in our documentation (note that this can be done in combination with bug 7137).
Comment 7 Samuel Mannehed cendio 2019-12-20 16:17:21 CET
There was further confusion regarding the custom compression level range in RFB proto. One place of the specification stated 1-9 and another 0-9, this has been sorted now, and the proper range is 0-9:


Fixed in TigerVNC for vncviewer:

Comment 10 Pierre Ossman cendio 2020-01-23 10:12:11 CET
Vendor drop of TigerVNC is now in place.
Comment 11 Pierre Ossman cendio 2020-01-23 10:16:25 CET
Looks good. Check tlclient and vncviewer options, as well as the documentation.

Note You need to log in before you can comment on or make changes to this bug.