Bug 5908 - tlclient and vncviewer option dialogs has very different window sizes
Summary: tlclient and vncviewer option dialogs has very different window sizes
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.6.0
Assignee: Peter Åstrand
URL:
Keywords: derfian_tester, prosaic
Depends on:
Blocks:
 
Reported: 2016-05-25 15:00 CEST by Peter Åstrand
Modified: 2016-05-30 15:22 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Russian translation after changes (30.13 KB, image/png)
2016-05-30 13:31 CEST, Karl Mikaelsson 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2016-05-25 15:00:42 CEST 
The tlclient options dialog is:

  Width: 520
  Height: 475

...while the vncviewer is:

  Width: 450
  Height: 450

This causes some problems, for example, the german translation Optimiering -> "Voll (alle verfugbaren Farben)" does not fit in the vncviewer dialog.
Comment 1 Peter Åstrand cendio 2016-05-25 15:23:19 CEST 
Also a problem with:

spanish translation (most dialogs)

italian translation (color dialog)

dutch translation (most dialogs)

brazilian portugese: string in color dialog barely fits

russian (most dialogs)

swedish: string in color dialog barely fits

turkish translation (color dialog)
Comment 3 Karl Mikaelsson cendio 2016-05-30 13:31:25 CEST 
Created attachment 705 [details]
Russian translation after changes
Comment 4 Karl Mikaelsson cendio 2016-05-30 13:33:43 CEST 
Most translations look fine now but the Russian still doesn't fit into the window.

There's also a small discrepancy in the translations - the "custom compression level" description is "level (1=fast, 6=best)" in tlclient options while it is "level (1=fast, 6=best [4-6 are rarely useful])" in vncviewer.
Comment 5 Peter Åstrand cendio 2016-05-30 13:42:03 CEST 
(In reply to comment #4)
> Most translations look fine now but the Russian still doesn't fit into the
> window.
> 
> There's also a small discrepancy in the translations - the "custom compression
> level" description is "level (1=fast, 6=best)" in tlclient options while it is
> "level (1=fast, 6=best [4-6 are rarely useful])" in vncviewer.

https://www.cendio.com/bugzilla/show_bug.cgi?id=5909
Comment 6 Karl Mikaelsson cendio 2016-05-30 15:22:38 CEST 
(In reply to comment #5)

OK.

tlclient options:
> $ xwininfo | egrep "(Height|Width):"
>   Width: 520
>   Height: 475

vncviewer options:
> $ xwininfo | egrep "(Height|Width):"
>   Width: 520
>   Height: 475

They're in sync right now. Good enough.
Note You need to log in before you can comment on or make changes to this bug.