Bug 8578 - Difficult to find license's max ThinLinc version as a system administrator
Summary: Difficult to find license's max ThinLinc version as a system administrator
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.19.0
Assignee: Samuel Mannehed
URL:
Keywords: aleze_tester, relnotes
Depends on:
Blocks:
 
Reported: 2025-04-21 14:23 CEST by Samuel Mannehed
Modified: 2025-04-28 13:48 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:
MUST * The maximum supported ThinLinc version, given a set of licenses, must be available in an easy way for the admin. SHOULD * The version should be available both through Web Admin and tlctl.

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Samuel Mannehed cendio 2025-04-21 14:23:01 CEST 
A ThinLinc license supports the newest ThinLinc version available when the license bundle was created, and older versions.

Sometimes customers install new license files without upgrading the ThinLinc server. This means it is possible to end up in a scenario where you, as an admin, are unsure what version you can upgrade to, without new licenses.

The best way to find that information is to open a license files under /opt/thinlinc/etc/licenses/, but this is not very convenient.

It would be cool if this information was available through `tlctl license` and Web Admin.
Comment 4 Samuel Mannehed cendio 2025-04-23 16:46:39 CEST 
Should be done. Tested on Fedora 41 using a set of licenses:

 * One license file with one version
 * Two different licenses with different versions

> MUST
> 
> * The maximum supported ThinLinc version, given a set of licenses, must be available in an easy way for the admin.
Yep, only the latest version from the license files is displayed.

> SHOULD
> 
> * The version should be available both through Web Admin and tlctl.
Yep.
Comment 9 Alexander Zeijlon cendio 2025-04-28 13:36:12 CEST 
Testing:
========

I have tested this in both tlwebadm and tlctl, where I see the same results.

* Using only one valid license-zip:

    "tlctl license show" lists which ThinLinc version the current license is
    valid for.


* Using multiple valid license-zips:

    "tlctl license show" lists which ThinLinc version the current set of
    licenses are valid for.


* Using only expired license-zips:

    "tlctl license show" finds no valid licenses and therefore falls back to
    using the 10 free licenses. No ThinLinc version compatibility info is
    printed.


* Using a combination of expired, old and valid license-zips:
    "tlctl license show" lists which ThinLinc version, the valid licenses are
    valid for.

To conclude, ThinLinc version compatibility is shown for licenses that are currently available for use. Licenses that the license handler has determined are expired or otherwise not usable by the current version of ThinLinc are not listed.

This behavior should be OK since, as mentioned in comment 0, the use case here is mainly to make it easier for sysadmins to get an idea of how far they can upgrade without their valid licenses becoming invalid in the process.
Comment 10 Alexander Zeijlon cendio 2025-04-28 13:48:09 CEST 
As a sanity check, I emulated the upgrade scenario described in comment 9 by building the server with a lower version number, just to make sure that we weren't missing any edge cases. Web admin and tlctl both list the same ThinLinc version compatibility.
Comment 11 Alexander Zeijlon cendio 2025-04-28 13:48:27 CEST 
Closing!
Note You need to log in before you can comment on or make changes to this bug.