Bug 8123 - Cannot add printer if location name is empty
Summary: Cannot add printer if location name is empty
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: 4.14.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-24 13:40 CET by Frida Flodin
Modified: 2023-04-19 16:51 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments
Patch that enables adding printer if location name is empty (3.25 KB, patch)
2023-04-19 16:51 CEST, Samuel Mannehed
Details | Diff

Description Frida Flodin cendio 2023-03-24 13:40:05 CET
If you add a new location, clear the "Location name" field and try to add a printer by pressing "Add printer", the popup closes. 

The expected behavior is probably that you should be able to add printers before you decide on a name. Since you haven't pressed "Save" yet, I would expect to be able to edit the location as I please.
Comment 2 Samuel Mannehed cendio 2023-04-19 16:51:27 CEST
Created attachment 1120 [details]
Patch that enables adding printer if location name is empty

With this patch, you can add printers even if the location name is empty. Additionally, the popup no longer incorrectly closes upon errors (bug 8103 comment 7).

However, with the patch, there are two remaining minor issues:

Can get ugly random name
------------------------

 1. Clicking "Add new location"
 2. Clearing the "Location name" field
 3. Pressing "Add printer"
 4. You now get an ugly random name, like "__new_entry_36988". The Locations/Terminals page behaves better in this scenario, you get to keep the empty name field when doing the same steps.

Possible to get locked location name
------------------------------------

 1. Clicking "Add new location"
 2. Clearing the "Location name" field
 3. Pressing "Add printer
 4. Pressing "Add printer" again
 5. You now get a locked "Location name" field which you can't change.

Note You need to log in before you can comment on or make changes to this bug.