Bug 8095 - Impossible to add printer to new terminal with empty hardware address
Summary: Impossible to add printer to new terminal with empty hardware address
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: 4.14.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Tobias
URL:
Keywords: frifl_tester
Depends on:
Blocks:
 
Reported: 2023-02-14 10:39 CET by Frida
Modified: 2023-03-24 16:02 CET (History)
1 user (show)

See Also:
Acceptance Criteria:
Clicking 'Add printer' when adding a new terminal should not exit the detailed view, regardless of current hardware address field input.

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Frida cendio 2023-02-14 10:39:47 CET 
Under Locations ⇾ Terminals, click "Add new terminal"
Make sure that the hardware address field is empty*.
Click "Add printer". The details view closes, and the terminal is gone.


*NOTE: There is a space as hardware address by default, this needs to be removed.
Comment 1 Frida cendio 2023-02-14 14:26:03 CET 
It's the same problem when adding new locations
Comment 2 Frida cendio 2023-02-20 09:11:57 CET 
The expected behavior is probably that you should be able to add printers before you decide on a name or hardware address. Since you haven't pressed "Save" yet, I would expect to be able to edit the Terminal or Location as I please.
Comment 4 Tobias cendio 2023-03-23 16:12:45 CET 
Should work now. Note that the overwrite phenomenon documented in bug 8084 is still a problem.
Comment 5 Frida cendio 2023-03-24 13:07:40 CET 
I still have the problem on locations page. When adding a new location, giving it an empty name, and clicking "Add printer" the popup is closed. It is not as bad as terminals page was before, since the name is not empty by default for locations.
Comment 6 Frida cendio 2023-03-24 13:46:11 CET 
Created a new bug for locations page, bug 8123.

The terminals page works just fine now. Tested the original problem, and it is now possible to add a printer when hardware address is empty. Note also that the "hidden" space mentioned in comment #0 has been removed as a part of this bug and bug 8075.
Note You need to log in before you can comment on or make changes to this bug.