Bug 8102 - Compatibility auto test filters errors incorrectly
Summary: Compatibility auto test filters errors incorrectly
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Automatic tests (show other bugs)
Version: trunk
Hardware: Other Other
: P2 Normal
Target Milestone: 4.15.0
Assignee: Alexander Zeijlon
URL:
Keywords: frifl_tester, prosaic
Depends on:
Blocks:
 
Reported: 2023-02-20 12:22 CET by Alexander Zeijlon
Modified: 2023-03-07 13:59 CET (History)
1 user (show)

See Also:
Acceptance Criteria:
* Parsable lines that are malformed due to the error line bug in vermin, should be "repaired" before being interpreted. * If the "reason" of a non-summary line output from vermin contains an error (f.ex. syntax error in the input file), we should fail that file even if the version string claims that the file passes our criteria for version of python.

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Alexander Zeijlon cendio 2023-02-20 12:22:07 CET 
When vermin checks for compatibility, it is too optimistic in guessing python version if the evaluated line happens to be interpreted as a syntax error. We want the test case test_python_compatibility in test_scripts.py to fail an input file if there is any chance of it containing invalid or incompatible code.

Additionally, parsable error lines are malformed due to a bug in vermin which means we need to have a work around to be able to treat these lines correctly.
Comment 3 Alexander Zeijlon cendio 2023-02-21 09:02:29 CET 
The bug has been reported to the vermin-page on GitHub:
https://github.com/netromdk/vermin/issues/150
Comment 4 Alexander Zeijlon cendio 2023-02-21 10:29:31 CET 
This has been fixed now.
Comment 5 Frida Flodin cendio 2023-03-07 13:59:37 CET 
Tested this and it seems to work fine. Syntax errors in files no longer pass through the tests.
Note You need to log in before you can comment on or make changes to this bug.