Bug 8101 - Too sparse information provided by compatibility auto test
Summary: Too sparse information provided by compatibility auto test
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Automatic tests (show other bugs)
Version: trunk
Hardware: Other Other
: P2 Normal
Target Milestone: 4.15.0
Assignee: Alexander Zeijlon
URL:
Keywords: frifl_tester, prosaic
Depends on:
Blocks:
 
Reported: 2023-02-20 10:44 CET by Alexander Zeijlon
Modified: 2023-03-08 15:55 CET (History)
1 user (show)

See Also:
Acceptance Criteria:
Each error in the test case should output: * a file-name * a line number * a column number (if it exists) * the reason for the error * the compatibility version of the error.

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Alexander Zeijlon cendio 2023-02-20 10:44:01 CET 
The test case test_python_compatibility in the file test_scripts.py currently only outputs the result of the summary line from vermin. The output of vermin is already parsed for per line reasons as to why there is a loss in compatibility. These "reasons" should be included in the failure message so that we know where in the tested file, the error can be found.
Comment 3 Alexander Zeijlon cendio 2023-02-21 10:27:46 CET 
This is fixed now. Keep in mind that this test should not run on files that are supposed to be python 2. Add these to the exceptions tuple at the top of test_python_compatibility().
Comment 4 Frida Flodin cendio 2023-03-07 14:07:19 CET 
Looks good and works fine. Tested by adding two lines of too new python code in the same file. Got a nice output with the line numbers and the reasons for vermin's decision.
Note You need to log in before you can comment on or make changes to this bug.