Bug 8076 - Incorrect header levels used in tlwebadm
Summary: Incorrect header levels used in tlwebadm
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: trunk
Hardware: Other Other
: P2 Normal
Target Milestone: 4.15.0
Assignee: Alexander Zeijlon
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2023-01-24 12:40 CET by Tobias
Modified: 2023-03-01 12:47 CET (History)
1 user (show)

See Also:
Acceptance Criteria:
* Header levels should not be skipped. This means that structurally, the next level below a h1 should always be a h2 and so on. * Changing to h2 from h3 increases the font size, and hence must not cause headers with larger font size to overflow or wrap its contents.


Attachments

Description Tobias cendio 2023-01-24 12:40:45 CET
Most pages header levels are using <h1> as the first header followed by <h3>. This is probably because the contrast between <h1> and <h2> was deemed too low.
Comment 2 Pierre Ossman cendio 2023-03-01 12:47:29 CET
Looks good. I can only find <h1> and <h2> in tladm now, and I can't find any <h2> that isn't preceded by a <h1>.

> * Header levels should not be skipped. This means that structurally, the next level below a h1 should always be a h2 and so on.

Yup.

> * Changing to h2 from h3 increases the font size, and hence must not cause headers with larger font size to overflow or wrap its contents.

The new size is indeed larger, but I think it still looks good.

I cannot find any heading that is long enough to wrap.

Note You need to log in before you can comment on or make changes to this bug.