Bug 8073 - too high displayed resolution of tlwebadm load data
Summary: too high displayed resolution of tlwebadm load data
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: trunk
Hardware: Other Other
: P2 Normal
Target Milestone: 4.15.0
Assignee: Tobias
URL:
Keywords: frifl_tester, prosaic
Depends on:
Blocks:
 
Reported: 2023-01-17 09:36 CET by Tobias
Modified: 2023-07-05 09:25 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tobias cendio 2023-01-17 09:36:04 CET 
It's not necessary to know the amount of memory left down to two decimals of a megabyte, especially since available memory nowadays is expected to be in the gigabyte range which ends up filling the columns with large numbers.

The displayed units are also inconsistent with tlctl, although that is not necessarily wrong.
Comment 6 Tobias cendio 2023-01-18 09:04:43 CET 
Columns on the tlwebadm/status/load page whose data formats have been altered are

Bogomips   : 2 -> 0 decimals
Load       : 3 -> 2 decimals
Mem total  : 2 -> 1 decimals & MB -> GB 
Mem free   : 2 -> 1 decimals & MB -> GB 
Swap total : 2 -> 1 decimals & MB -> GB 
Swap free  : 2 -> 1 decimals & MB -> GB 
Rating     : 2 -> 1 decimals

Seems to be working as intended.
Comment 8 Tobias cendio 2023-01-26 12:41:59 CET 
Commit r39574 made the Rating column number of decimals consistent with tlctl. It was mistakenly referred to bug 7909.
Comment 9 Frida Flodin cendio 2023-01-30 14:46:08 CET 
Looks good! There are now a more reasonable number of decimals, and the change to GiB looks correct. Checked the code changes and could not find any issues.
Note You need to log in before you can comment on or make changes to this bug.