Comment 2 Samuel Mannehed 2022-12-23 17:21:18 CET

The new fonts have been applied to Web Admin now. I have not looked through if the appropriate font (Mulish vs Poppins vs SpaceMono) is used in all places.

Comment 5 Pierre Ossman 2023-02-28 09:40:44 CET

Need to also check that we use semibold, not bold, for the elements that use Poppins.

Comment 6 Alexander Zeijlon 2023-03-21 10:29:19 CET

Poppins is now applied to all label texts beside checkboxes and radio buttons.

Comment 19 Tobias 2023-05-03 15:48:24 CEST

The fonts Mulish, Poppins, and Space-Mono, with appropriate font weights, should be correctly applied across the modules now.

Comment 20 Alexander Zeijlon 2023-05-04 16:01:55 CEST

Code verification:
- The code looks good except for one line of commented out code that can be removed, see comment 12.

Verification of acceptance criteria:
- Two points have not been fulfilled, both concern missing application of monospace font, see below.

Poppins should be used for:
[✓] Headers
[✓] Table content; short strings
[✓] Input fields
[✓] Buttons
[✓] Labels

Mulish should be used for:
[✓] Regular text
[✓] Table content; longer strings
  * We currently do not have longer strings in tables outside of textareas.
[✓] Textareas

Space Mono should be used for:
[✓] Commands
[✓] Code
[X] Locale
  * Language codes in Introduction Texts and in Profile Lists are not using Space Mono.
[X] IP addresses
  * The IP address in the session information pop-up is not using Space Mono.
[✓] MAC addresses
[✓] Paths

Bold font weights should be used for:
[✓] 600 for Poppins
[✓] 700 for Mulish
[✓] 700 for Space Mono

Comment 21 Alexander Zeijlon 2023-05-05 08:56:04 CEST

(In reply to Alexander Zeijlon from comment #20)
> Space Mono should be used for:
> [X] MAC addresses
> * The Terminal ID (MAC) in the session information pop-up is not using Space Mono.

Comment 22 Alexander Zeijlon 2023-05-05 09:18:50 CEST

(In reply to Alexander Zeijlon from comment #20)
> Space Mono should be used for:
> [X] Commands
>   * The Command in the session information pop-up is not using Space Mono.

Comment 23 Linn 2023-05-05 12:29:39 CEST

Updated acceptance criteria to include that language codes should have Space Mono font.

Comment 26 Linn 2023-05-05 13:04:15 CEST

My bad, acceptance criteria for SpaceMono font already contained language codes under bullet point "Locale".

Comment 27 Linn 2023-05-05 13:21:15 CEST

Checked that session information pop-up behaves as expected:

- Uses monospace font in the following fields:
 * Last connection
 * Agent
 * Agent server address
 * Terminal ID
 * Command
- Uses Poppins when displaying N/A value

Comments
--------
In Last connection, only the IP address should be monospace. Log in with the native client for the IP to show. 

Also, note that the agent field can be both IP addresses and DNS names, but to get consistency between Agent and Agent server address fields both fields always use monospace regardless of the content of Agent field.


With this, the comments from comment 21 and comment 22 have been addressed.

Comment 28 Linn 2023-05-05 13:32:44 CEST

(In reply to Alexander Zeijlon from comment #20)
> ...
> Space Mono should be used for:
> [X] Locale
>   * Language codes in Introduction Texts and in Profile Lists are not using Space Mono.
The language code in both tables on Introduction Texts now use monospace font. 
Text where the language code is referenced now also uses monospace font for that reference, found on the following pages:

 * Profile Lists pop-up, in translations for names and descriptions
 * Applications (Manual) pop-up, Application name (<lang code>)
 * Menu Structure pop-up, Menu name (<lang code>)

With that, all comments should be fixed and this bug should be ready for retesting.

Comment 30 Linn 2023-05-08 09:18:32 CEST

(In reply to Linn from comment #27)
> ...
> Also, note that the agent field can be both IP addresses and DNS names, but
> to get consistency between Agent and Agent server address fields both fields
> always use monospace regardless of the content of Agent field.

While this gets consistency between fields Agent and Agent server adress, showing hostnames in monospace differs from how we present them in other places. It's better to be consistent over Web Admin as a whole, reopening to change these fields back to our regular font.

Comment 32 Linn 2023-05-08 09:32:05 CEST

In the session information pop-up, fields Agent and Agent server address now use the regular font, leaving the fields below as the only ones using monospace:

 * Last connection
 * Terminal ID
 * Command

Comment 34 Linn 2023-05-08 11:00:49 CEST

Correction to comment 32:

The only fields that should use monospace fonts in the session pop-up are:
 * Terminal ID
 * Command

Field "Last connection" contains an IP address, which should be shown in our regular font.

Comment 35 Tobias 2023-05-08 11:07:13 CEST

The shortcomings reported in comment 20 regarding monospace have been
addressed in comment 27 and comment 28. Instances of monospace was later
reduced to not include IPs/hostnames -- see comment 30. All font
corrections have been checked and seem to be in order.

Closing.