Bug 7951 - Poor wrapping of platform specific notes url
Summary: Poor wrapping of platform specific notes url
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Pierre Ossman
Keywords: prosaic, wilsj_tester
Depends on:
Reported: 2022-06-22 12:49 CEST by Pierre Ossman
Modified: 2022-06-28 16:36 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Pierre Ossman cendio 2022-06-22 12:49:04 CEST
The word wrapping around the platform specific URL on the first page of tl-setup can end up a bit broken, depending on the e.g. the font used. On a standard Fedora 36 I get the word "at" by itself on a line, with the URL on the following line, despite there being room for both.

The reason for this is a workaround for Pango's overly aggressive word wrapping that can split URLs. We simply add a line break before the URL so that it has a complete line by itself.

However, in r27688 for bug 4757, we added a better way to stop Pango from breaking lines in an undesirable way. We should use that instead to get something more sensible.

(note that tlinstaller also shows the same URL, but has no odd issues)
Comment 2 Pierre Ossman cendio 2022-06-22 14:07:32 CEST
Fixed. We now use sanitise_wrap() consistently, and the wrapping is much better.
Comment 3 William Sjöblom cendio 2022-06-28 16:36:16 CEST
Tested using various font sizes with server build #2724 on Fedora 35 and things look good. Also had a look through the code without finding any remaining instance of `linkify_text()' being used without `sanitise_wrap'.

Marking as closed.

Note You need to log in before you can comment on or make changes to this bug.