Bug 4757 - proper finish page in installer and tl-setup
Summary: proper finish page in installer and tl-setup
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.1.1
Assignee: Pierre Ossman
URL:
Keywords: hean01_tester, prosaic
Depends on:
Blocks:
 
Reported: 2013-07-17 12:01 CEST by Pierre Ossman
Modified: 2013-10-24 11:02 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments
Screenshot of start page. (47.55 KB, image/png)
2013-10-21 09:23 CEST, Henrik Andersson
Details

Description Pierre Ossman cendio 2013-07-17 12:01:55 CEST
The last page of the installer and tl-setup doesn't really have the correct look (as far as copying the look of Windows installer goes). It should basically look the same as the first page.
Comment 1 Pierre Ossman cendio 2013-07-17 13:13:51 CEST
Fixed in r27688 through r27690.
Comment 2 Aaron Sowry cendio 2013-07-25 15:12:50 CEST
The obfuscator is obfuscating tlgtk.sanitise_wrap (and possibly others), without taking into account the needs of tlinstaller which tries to call sanitize_wrap by name. This breaks the installer.

I can't remember the details of how this is supposed to work, perhaps someone else knows.
Comment 3 Pierre Ossman cendio 2013-08-13 13:42:41 CEST
(In reply to comment #2)
> The obfuscator is obfuscating tlgtk.sanitise_wrap (and possibly others),
> without taking into account the needs of tlinstaller which tries to call
> sanitize_wrap by name. This breaks the installer.
> 
> I can't remember the details of how this is supposed to work, perhaps someone
> else knows.

r27772.
Comment 4 Henrik Andersson cendio 2013-10-21 09:23:53 CEST
Created attachment 494 [details]
Screenshot of start page.
Comment 5 Henrik Andersson cendio 2013-10-21 09:27:35 CEST
(In reply to comment #4)
> Created an attachment (id=494) [details]
> Screenshot of start page.

Tested using ThinLinc build 4122, wizard finish page looks all good.
However the start page looks a bit fishy with its long title which is wrapped in three and steals 40% of info page. Not the best screen real estate...
Comment 6 Henrik Andersson cendio 2013-10-21 11:11:52 CEST
(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=494) [details] [details]
> > Screenshot of start page.
> 
> Tested using ThinLinc build 4122, wizard finish page looks all good.
> However the start page looks a bit fishy with its long title which is wrapped
> in three and steals 40% of info page. Not the best screen real estate...

New bug #4860 created for the strange word wrap.

Note You need to log in before you can comment on or make changes to this bug.