Bug 7906 - Session startup should follow new visual profile
Summary: Session startup should follow new visual profile
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Pierre Ossman
URL:
Keywords: frifl_tester, relnotes, tobfa_tester, wilsj_tester
Depends on: 3054 7905
Blocks: 7903
  Show dependency treegraph
 
Reported: 2022-04-27 10:16 CEST by Pierre Ossman
Modified: 2023-08-08 18:38 CEST (History)
4 users (show)

See Also:
Acceptance Criteria:
* The font cache dialogue follows the new visual profile * The progress dialogue uses the new logo * The default background colour follows the new visual profile * The default background image follows the new visual profile Stretch: * The progress dialogue follows the GNOME HIG


Attachments
Screenshot showing the new thinner blue bar (20.42 KB, image/png)
2023-08-04 17:51 CEST, Samuel Mannehed
Details

Description Pierre Ossman cendio 2022-04-27 10:16:11 CEST
We have a new visual profile that should be followed in the xstartup feedback dialog and the default background.
Comment 8 Pierre Ossman cendio 2022-06-27 14:38:08 CEST
For the background image, we want to include the normal logo, and the hand drawn figures. But these can look very bad if we start to distort the image (which happens if the session size doesn't match the aspect ratio of the image). So we want to switch to a different scaling principle.

The one everyone else seems to use is what is often called "zoom"¹. This method retains the aspect ratio, but scales the image so that the entire screen is covered, and as much as possible of the image is shown. Any mismatch is handled by centering the image on the screen.

Hopefully this method can be good enough for us.

¹ GNOME have even gone as far as removing all other methods
Comment 9 Pierre Ossman cendio 2022-06-27 14:39:10 CEST
GNOME's HIG also has some details around background:

https://developer.gnome.org/hig/reference/backgrounds.html
Comment 13 Pierre Ossman cendio 2022-06-27 16:28:37 CEST
Everything should now be in place.

> * The font cache dialogue follows the new visual profile

Yup. Uses colors, logo and figures from new profile.

> * The progress dialogue uses the new logo

Yup. Also centered to match the changes in the profile chooser.

> * The default background colour follows the new visual profile

Yup. Uses just plain white, as that is what covers most of the default background image. That way there isn't a massive difference if the image fails to load, or takes some time to load.

> * The default background image follows the new visual profile

Yup. Uses colors, logo and figures from new profile.

> Stretch:
> 
> * The progress dialogue follows the GNOME HIG

I guess. Only made minor adjustments. The HIG recommends against using both spinners and progress bars, but I think removing one of them is the worse option here. We have progress information that we want to show, but we also have steps that can take a long time, so we want some animation to indicate that things haven't locked up.
Comment 14 William Sjöblom cendio 2022-06-29 15:53:22 CEST
I've tested server build #2726 on SLES12 without any issues.

• The font cache dialog follows the new visual profile

  Yep, looks great!

• The progress dialog uses the new logo

  Yup, the new logo is in place and looks sharp and pretty!

• The default background color follows the new visual profile

  Yep! The white works well as an alternative!

• The default background image follows the new visual profile

  Yep… There were also some background scaling changes done as part of
  this bug. The scaling has been tested successfully with the following
  background dimensions on a 1920x1200 framebuffer: 4096×2048, 4096×512,
  4096×8192, 1024×8192.

  Additionally, I've also tested a bunch of different aspect ratios and
  multi-head configurations without any issues apart from those in bug
  7952 and bug 7949.


• The progress dialog follows the GNOME HIG

  At least somewhat. As previously mentioned the spinner+progressbar
  combination is somewhat unorthodox from a GNOME stand-point, still I
  think this is acceptable.

Closing!
Comment 15 Tobias cendio 2022-07-05 15:04:04 CEST
In the TAG under "Parameters in /sessionstart/" it's claimed that the default background color is dark blue, while it's in fact black.
Comment 17 Pierre Ossman cendio 2022-07-05 15:46:24 CEST
Documentation is now fixed.
Comment 18 Tobias cendio 2022-07-07 12:47:54 CEST
The documentation inconsistencies mentioned in comment 15 are now in place and both html and pdf versions looks good.

Closing.
Comment 21 Samuel Mannehed cendio 2023-08-04 17:05:24 CEST
After applying our new visual profile to more parts of our product we have ended up using slightly different "blue lines". In particular, the blue line graphic in tl-fontcache looks too high compared to other components.

The blue graphic at the bottom of the tl-fontcache background is in absolute numbers approximately the same as the maximum height of the blue line in Web Access and Web Admin. But since the total size of the area it appears in (the fontcache window) is smaller, the proportions are off. We should reduce the height of this blue line.

A rough guideline is ~3% of the height of its immediate area. However, smaller areas, such as the top portion of the client login window, warrant a bit more than 3% to not look silly. The blue line in the macOS installer image (bug 7976) was updated to 13px out of 353px height, this is ~3.7%.

The fontcache window's height is 198px. Currently, the blue line is 16px high, this is ~8.1%. I think something like a 7px height (~3.5%) would be suitable.
Comment 23 Samuel Mannehed cendio 2023-08-04 17:36:20 CEST
This has been fixed now, the blue line in the tl-fontcache background is now 7px (3.5% of the height).

It looks much more in line with the rest of the product now.
Comment 25 Samuel Mannehed cendio 2023-08-04 17:51:02 CEST
Created attachment 1147 [details]
Screenshot showing the new thinner blue bar

Note that the throbber was moved 3px down to appear more centered in the area below the figure.
Comment 26 Frida Flodin cendio 2023-08-08 16:17:09 CEST
I think this looks much better now with the thinner blue line. Also agree with the move of the throbber. Looks good, closing.

Note You need to log in before you can comment on or make changes to this bug.