Bug 7362 - Upgrade GCC to latest 5.x
Summary: Upgrade GCC to latest 5.x
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Build system (show other bugs)
Version: trunk
Hardware: PC All
: P2 Normal
Target Milestone: 4.11.0
Assignee: Samuel Mannehed
URL:
Keywords: ossman_tester, prosaic, samuel_tester
Depends on:
Blocks: 7366
  Show dependency tree / graph
 
Reported: 2019-08-08 13:40 CEST by Samuel Mannehed
Modified: 2024-06-10 12:53 CEST (History)
0 users

See Also:
Acceptance Criteria:
* We should be using the latest 5.x version in our build environment * Our binaries should work on every of our targets (testing the client and its local redirections is sufficient)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Samuel Mannehed cendio 2019-08-08 13:40:33 CEST 
We need the bug fixes in the latest version to avoid compiler crashes.
Comment 3 Pierre Ossman cendio 2019-08-19 15:00:49 CEST 
> * We should be using the latest 5.x version in our build environment

Indeed. All gcc are upgraded to 5.5.0 on chavez.

> * Our binaries should work on every of our targets (testing the client and its local redirections is sufficient)

Works well. Tested tlclient and audio on:

 * i386 (Fedora 30)
 * x86_64 (Fedora 30)
 * Win32 (Windows 10)
 * Win64 (Windows 10)
 * ARM (Eltex)
 * osx64 (macOS 10.14)

Also tested entering the wrong password to make sure exceptions work (known problem area on Windows and macOS).
Comment 4 Pierre Ossman cendio 2019-10-02 08:53:52 CEST 
Found an issue where gcc tries to "fix" OpenSSL's bn.h (and other stuff). That just means we get an old version of this header included with gcc that won't be updated when we update OpenSSL.

Distributions seem to nuke this fixing system, so let's do the same for our gcc builds.
Note You need to log in before you can comment on or make changes to this bug.