Bug 7290 - We are not using the latest version of libjpeg-turbo
Summary: We are not using the latest version of libjpeg-turbo
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.12.0
Assignee: Pierre Ossman
URL:
Keywords: prosaic
Depends on: 7291
Blocks:
  Show dependency treegraph
 
Reported: 2018-12-10 10:58 CET by Peter Åstrand
Modified: 2020-01-20 09:54 CET (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Peter Åstrand cendio 2018-12-10 10:58:00 CET
Currently, we are using libjpeg-turbo 1.5.3. The latest verison is 2.0.1. There are some performance improvements; not sure if we would benefit from these though. See: https://github.com/libjpeg-turbo/libjpeg-turbo/releases
Comment 1 Pierre Ossman cendio 2020-01-16 10:40:59 CET
The new versions have switched over completely to CMake as the build system. This exposed some issues in CMake when it comes to cross-compiling that we need to fix.
Comment 5 Pierre Ossman cendio 2020-01-17 09:11:39 CET
A quick test suggests this now works. We need to properly check some things though:

 * Compatibility with old versions (server/client)

 * Performance/CPU usage for each arch (remember bug 7463 though)
Comment 7 Niko Lehto cendio 2020-01-17 13:54:42 CET
Tested with Fedora 30 client side, Ubuntu 18.04 and RHEL 7 servers. (4.11.0 and build 6360).
                  |Server 4.11.0  Server 4.11.0post|
------------------+--------------+-----------------+
Client 4.11.0     |       ✓      |       ✓         |
------------------+--------------+-----------------+
Client 4.11.0post |       ✓      |       ✓         |
------------------+--------------+-----------------+

These seems to work fine with no noticeable performance changes between versions.
Comment 8 Niko Lehto cendio 2020-01-17 16:28:06 CET
Also tested 4.11.0 and 4.11.0post clients on the following archs:
✓ i686
✓ armhf
✓ win32 
✓ win64
✓ macOS

These also seems to work fine with no noticeable performance changes between
versions.

Note You need to log in before you can comment on or make changes to this bug.