Bug 6994 - the client is incorrectly shown as "tlclient" in some places in Windows
Summary: the client is incorrectly shown as "tlclient" in some places in Windows
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client platforms (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.9.0
Assignee: Henrik Andersson
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks: 6996
  Show dependency tree / graph
 
Reported: 2017-06-19 15:11 CEST by Pierre Ossman
Modified: 2017-07-06 15:12 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2017-06-19 15:11:52 CEST 
There are a few places where the ThinLinc client is shown as "tlclient" rather than it's proper "ThinLinc client" name:

 - Right-clicking the icon in the task bar
 - In the task manager

This looks rather bad as other applications have this properly sorted out.

One guess is that this information is grabbed from the executable, as we currently do not fill out the product name field.

We also need to make sure this is translated, and check if vncviewer also needs to be modified.
Comment 1 Pierre Ossman cendio 2017-06-19 15:14:47 CEST 
(In reply to comment #0)
> 
> One guess is that this information is grabbed from the executable, as we
> currently do not fill out the product name field.
> 

This theory seems to hold as vncviewer.exe is shown as "ThinLinc Client"*, which is what is stored in the executable's product name field.

*Not translated though
Comment 2 Henrik Andersson cendio 2017-07-03 14:12:44 CEST 
Adding a VERSIONINFO structure to executable resources gives us:

 - Properties -> Information on executable shows proper version,company 
   ,copyright etc.

 - Task manager entry is now "ThinLinc Client" instead of tlclient

However, this change did not affect the problem were the menu title is tlclient when right clicking on the icon on task bar while program is running.
Comment 6 Henrik Andersson cendio 2017-07-05 13:18:19 CEST 
 (In reply to comment #2)
> 
> However, this change did not affect the problem were the menu title is tlclient
> when right clicking on the icon on task bar while program is running.

This is true only when tlclient.exe is executed outside of an installation.
Comment 7 Pierre Ossman cendio 2017-07-06 15:12:46 CEST 
Looks nice. Checked both taskbar and task manager, as well as both tlclient and vncviewer.
Note You need to log in before you can comment on or make changes to this bug.