Some users might need all the screen real estate possible, especially on mobile devices. The control bar takes up quite a lot of space at the top of the screen.
One solution for showing the control bar could be a floating, movable button along the edge. We could also use the F8 key on desktop to show the control bar, but we still need a solution for mobile devices. See bug 4922.
We now have two pull requests upstream as a result of this work: https://github.com/kanaka/noVNC/pull/651 https://github.com/kanaka/noVNC/pull/653 We don't have time to wait for these to be merged, so we'll do a local commit and get back in sync at a later point.
All done. Tester should verify the toolbar with our usual matrix of tested browsers.
(In reply to comment #11) > All done. Tester should verify the toolbar with our usual matrix of tested > browsers. More specifically, the tester should verify the buttons in the toolbar and the general functionality for controlling the toolbar appearance. Lastly, the tester should verify that automatic resize of the session still works as well. The buttons in the toolbar are: * Panning (touch only) * Mouse buttons (touch only) * Clipboard * Extra keyboard keys (also displays on-screen keyboard on touch) * Disconnect The matrix of tested browsers can be found here: http://intranet/ThinLinc/Testing#HTML5_client_Tests_.2BIxg-
When the browser window is made small enough, the menu handle can disappear off-screen.
When disconnecting, the "disconnected"-message is shown in a white rounded box which often will show up on a white background page. A thin border around the box should improve visual appearance in this case.
The Shift and AltGr buttons on the keyboard fold out does not work in situations where you would expect them too. E.g. it is not possible to activate Shift and then press a single letter key on the keyboard to get an uppercase letter. Neither can you create an alternate character such as 'ø' (created by AltGr+ö on Swedish keyboards) by activating AltGr and then pressing 'ö' (this simply generates 'ö'). It seems this is related to the way the browser captures and propagates keypresses, characters, symbols and events. There might be situations where the AltGr could be used, e.g. superuser creating isoteric keyboard shortcuts. With the Shift and AltGr toggles present a common user might think that they can be used in the way described above. This would be confusing and generate support issues.
Should be fixed now.
As discussed on the developer meeting today, we have decided to reopen this due to the layout of the new toolbar. Currently there is unused space at the bottom in the toolbar which we feel should be removed in order to make the toolbar smaller. This becomes an issue when using the HTML5 client in small browsers (small height) since the toolbar always attempts to center itself. As the browser height becomes increasingly lower, and surpasses the height of the toolbar, more and more of the buttons will be placed outside the viewport. We can mitigate this problem by removing the unused space at the bottom.
(In reply to comment #13) > When the browser window is made small enough, the menu handle can disappear > off-screen. This is fixed now
Should be all fixed now.
Test report from Linux browsers, both tested with ThinLinc 4.6.0post, build 5239. * Firefox 48.0.1 on Fedora 24 x86_64 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide menu ✓ Move menu handle * Google Chrome 53.0.2785.116 on Fedora 24 x86_64 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide menu ✓ Move menu handle
Test report from Windows browsers, all tested with ThinLinc 4.6.0post, build 5239. Test server is an Ubuntu 16.04. * Firefox 48.0.2 on Windows 10 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle * Google Chrome 53.0.2785.116m on Windows 10 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle * Internet Explorer 11 (11.545.10586.0/11.0.34) on Windows 10 Clicking on the show/hide handle makes the mouse pointer disappear and all clicks will toggle the toolbar visibility. * Edge 25.10586.0.0 on Windows 10 Fails to redirect to the agent - the client never starts.
(In reply to comment #28) > * Internet Explorer 11 (11.545.10586.0/11.0.34) on Windows 10 > > Clicking on the show/hide handle makes the mouse pointer disappear > and all clicks will toggle the toolbar visibility. Fixed in 31726. > * Edge 25.10586.0.0 on Windows 10 > > Fails to redirect to the agent - the client never starts. Can reproduce on Edge 25 but not on Edge version 39. It seems like Windows updated Edge with the "Anniversary Update" and this seems to have fixed something. However, this seems to be a regression since Edge 25 works in the HTML5 client on a ThinLinc 4.6.0 server. Will investigate further.
(In reply to comment #32) > Can reproduce on Edge 25 but not on Edge version 39. It seems like Windows > updated Edge with the "Anniversary Update" and this seems to have fixed > something. > > However, this seems to be a regression since Edge 25 works in the HTML5 client > on a ThinLinc 4.6.0 server. Will investigate further. Further investigation shows that this isn't a regression after all. The issue is that Edge doesn't show the dialogue for accepting an unsigned certificate for the agent if the agent hostname is different from the address of the master you connected to. Added bug 5997 for this. Marking as resolved - ready for testing once again.
Moving the controlbar handle doesn't work in Safari on iOS, we get an exception: TypeError: TouchEventConstructor is not a constructor (evaluating 'new e.constructor(e.type, e)')
More test report from previously failing Windows browsers. All tested with ThinLinc 4.6.0post, build 5241. Test server is an Ubuntu 16.04. * Internet Explorer 11 (11.545.14393.0/11.0.35) on Windows 10 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle * Edge 38.14393.0.0 on Windows 10 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle Edge is still REALLY picky about hostnames. See bug 5997 for more details.
(In reply to comment #34) > Moving the controlbar handle doesn't work in Safari on iOS, we get an > exception: > > TypeError: TouchEventConstructor is not a constructor (evaluating 'new > e.constructor(e.type, e)') Fixed in r31740. Due to the amount of changes made, we think it's best to retest everything: The tester should verify the buttons in the toolbar and the general functionality for controlling the toolbar appearance. Lastly, the tester should verify that automatic resize of the session still works as well. The buttons in the toolbar are: * Panning (touch only) * Mouse buttons (touch only) * Clipboard * Extra keyboard keys (also displays on-screen keyboard on touch) * Disconnect The matrix of tested browsers can be found here: http://intranet/ThinLinc/Testing#HTML5_client_Tests_.2BIxg-
MacOS: Chrome, Safari and Firefox tested : Passed.
Test report from Windows browsers, all tested with ThinLinc 4.6.0post-5241.r31740. Test server is an Ubuntu 16.04. * Firefox 48.0.2 on Windows 10 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize * Google Chrome 53.0.2785.116m on Windows 10 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize * Internet Explorer 11 (11.545.14393.0/11.0.35) on Windows 10 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize * Edge 38.14393.0.0 on Windows 10 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize
Partial test report from Android browsers, all tested with ThinLinc 4.6.0post-5241.r31740. Test server is an Ubuntu 16.04. * Google Chrome 53.0.2785.124 on Android 5.1.1 (Nexus 7) The on-screen keyboard disappears if you: - hide the toolbar - press the mouse button button - press the clipboard button I haven't got panning to work at all yet, but I believe the keyboard will disappear if you press the panning button as well.
I have tested chrome and firefox on linux platform and have a few inputs to the implementation, otherwise it works as expected. Firefox 48.0.1 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize Chrome 53.0.2785.116 ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize [1] I expect a toolbar to have a few buttons / indicators showing states, with the current implementation the keyboard states are buried into sub menu. A user can not hide and then show the toolbar and see states directly without clicking down the keyboard submenu. One possible workaround could be that menu / submenu states are saveed and when showing toolbar the keyboard submenu is also expanded. [2] the items in the toolbar are seleectable which looks not so great when accidentally done. [3] The alt state indicator is easily taken out of sync. Press alt through menu and then alt on keyboard.
(In reply to comment #41) > > [1] I expect a toolbar to have a few buttons / indicators showing states, with > the current implementation the keyboard states are buried into sub menu. A user > can not hide and then show the toolbar and see states directly without clicking > down the keyboard submenu. One possible workaround could be that menu / submenu > states are saveed and when showing toolbar the keyboard submenu is also > expanded. > Also, this is inconsitent behaviour between keyboard key states and mouse states which actually is visible on the main toolbar.
(In reply to comment #40) > Partial test report from Android browsers, all tested with ThinLinc > 4.6.0post-5241.r31740. Test server is an Ubuntu 16.04. > > * Google Chrome 53.0.2785.124 on Android 5.1.1 (Nexus 7) > > The on-screen keyboard disappears if you: Also: - Press the Ctrl-Alt-Delete button - pressing other "key" buttons does not hide keyboard.
(In reply to comment #40) > The on-screen keyboard disappears if you: > > - hide the toolbar > - press the mouse button button > - press the clipboard button (In reply to comment #43) > - Press the Ctrl-Alt-Delete button - pressing other "key" buttons does not > hide keyboard. These items were fixed in r31744.
(In reply to comment #45) > (In reply to comment #40) > > The on-screen keyboard disappears if you: > > > > - hide the toolbar > > - press the mouse button button > > - press the clipboard button > > (In reply to comment #43) > > - Press the Ctrl-Alt-Delete button - pressing other "key" buttons does not > > hide keyboard. > > These items were fixed in r31744. Correction: > > - press the mouse button button > > - press the clipboard button Disappearing keyboard in these above cases were not fixed, not a regression.
(In reply to comment #41) > [1] I expect a toolbar to have a few buttons / indicators showing states, with > the current implementation the keyboard states are buried into sub menu. A user > can not hide and then show the toolbar and see states directly without clicking > down the keyboard submenu. One possible workaround could be that menu / submenu > states are saveed and when showing toolbar the keyboard submenu is also > expanded. I believe that users use these buttons temporarily and don't regard them as permanent states. I think the current behavior is good enough. > [2] the items in the toolbar are seleectable which looks not so great when > accidentally done. Not a regression, opened bug 6010 for this. > [3] The alt state indicator is easily taken out of sync. Press alt through menu > and then alt on keyboard. Not a regression, opened bug 6009 for this.
Test report from IOS browsers, all tested with ThinLinc 4.6.0post-5241.r31746. Test server is an Fedora 24. * Firefox Version 5.1(1) on Ipad mini ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize * Google chrome Version 52.0.2743.84 on Ipad mini ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize * Safari Version 537.36 on Ipad mini ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize
Test report from Android browsers, both tested with ThinLinc 4.6.0post, build 5243-r31742 (from jenkins). * Firefox 49 on Android 5.1.1 ✓ Panning button ✓ Mouse button ✓ Toggle keyboard ✓ Hotkey submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move toolbar handle * Google Chrome 53.0.2785.124 on Android 5.1.1 ✓ Panning button ✓ Mouse button ✓ Toggle keyboard ✓ Hotkey submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move toolbar handle
Test report from IOS browsers on ISO10, all tested with ThinLinc 4.6.0post-5241.r31746. Test server is an Fedora 24. * Firefox Version 5.3(2) on Ipad mini ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize * Google chrome Version 53.0.2784.109 on Ipad mini ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize * Safari Version 10 on Ipad mini ✓ Keyboard submenu: Ctrl, Alt, Tab, Escape and Ctrl-Alt-Delete ✓ Clipboard ✓ Disconnect ✓ Show/hide toolbar ✓ Move menu handle ✓ Session resize
Found two issues with the handle: - Sometimes it will start at the very top of the control bar - The coordinates for the dragging get screwed up if the page is scrolled down a bit.
(In reply to comment #51) > Found two issues with the handle: > > - Sometimes it will start at the very top of the control bar Fixed in r31807. > - The coordinates for the dragging get screwed up if the page is scrolled down > a bit. Fixed in r31806. The tester should verify that moving the handle still works as expected on all platforms and browsers.
(In reply to comment #54) > (In reply to comment #51) > > > > - Sometimes it will start at the very top of the control bar > > How to force reproduce the bug: - Open debug mode in browser and find element named noVNC_control_bar - Change css and add 'display: none' for the above element - Resize browser window to trig a resize - Remove 'display: none' as added above to show toolbar > > - The coordinates for the dragging get screwed up if the page is scrolled down > > a bit. How to reproduce: - use xrandr within a session and set a big screen size to view the scrollbars - scroll down a bit using scrollbar - now while dragging the control bar handle it has an offset of pixels matching scroll
We got a report from a customer that got this traceback on the beta release. > About Safari: > - Error is "TypeError: UI.popupStatus is not a function. (In > 'UI.popupStatus(msg)', 'UI.popupStatus' is undefined)" within > ui.js.
(In reply to comment #56) > We got a report from a customer that got this traceback on the beta release. > > > About Safari: > > - Error is "TypeError: UI.popupStatus is not a function. (In > > 'UI.popupStatus(msg)', 'UI.popupStatus' is undefined)" within > > ui.js. Fixed in r31812. This fix was very small and limited to error handling in a corner case, so this does not mean that we have to retest anything. Easy way to reproduce: 1. login using the HTML5 client 4.7.0beta1 2. disconnect (don't log out) 3. on the server, remove /var/opt/thinlinc/sessions/<username>/last/vncpasswd 4. reconnect As soon as the new build (5267) is completed this can be tested.
(In reply to comment #56) > We got a report from a customer that got this traceback on the beta release. > > > About Safari: > > - Error is "TypeError: UI.popupStatus is not a function. (In > > 'UI.popupStatus(msg)', 'UI.popupStatus' is undefined)" within > > ui.js. Verified that this works now.
(In reply to comment #51) > Found two issues with the handle: > > - Sometimes it will start at the very top of the control bar > > - The coordinates for the dragging get screwed up if the page is scrolled down > a bit. No regressions seen on Android or iOS for these fixes. Tested Safari, Chrome and Firefox.
Verified that Thinlinc 4.7.0rc3 fixes the problem on linux platform. - Chrome 54.0.2785.116 - Firefox v49.0
Tested Safari, Firefox and Chrome on macOS as well. That should be all. Closing.
