Bug 4942 - clean up tlwebadm/tlwebaccess code sharing
Summary: clean up tlwebadm/tlwebaccess code sharing
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.13.0
Assignee: Pierre Ossman
URL:
Keywords: nikle_tester, prosaic
: 5036 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-13 13:14 CET by Pierre Ossman
Modified: 2020-10-12 14:21 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2013-12-13 13:14:53 CET 
We now have two web servers in the product: tlwebadm and tlwebaccess. Unfortunately the code is very poorly structured. tlwebaccess is more or less a complete copy of tlwebadm, which means we have to remember to fix everything in two places.

The support library for tlwebadm modules also got moved into tlmisc. But half of the stuff in there is specific to tlwebadm and its module design rather than a generic web thing. We need better separation of general and specific things.
Comment 1 Pierre Ossman cendio 2013-12-13 13:57:39 CET 
A restructure will probably warrant a new security audit in line with bug 4853.
Comment 2 Pierre Ossman cendio 2014-02-21 15:48:35 CET 
Bug 4999 might be relevant when doing this as well.
Comment 3 Karl Mikaelsson cendio 2014-03-21 12:28:13 CET 
*** Bug 5036 has been marked as a duplicate of this bug. ***
Comment 5 Pierre Ossman cendio 2019-01-30 11:04:29 CET 
A lot of work towards this goal was done on bug 7187 and 7289 where they got some base classes for the most fundamental stuff.
Comment 25 Pierre Ossman cendio 2020-09-21 11:06:32 CEST 
Should be all done now. Tester needs to do a general check of tlwebaccess and tlwebadm. The following areas have been changed:

Web Access:

 * Login form in web access
 * Session handling
 * VNC page (including error handling for people loading page directly)
 * New URLs, and redirection for old URLs

tlwebadm:

 * JavaScript loading (used by profile configuration)
 * Translation handling (used by profile configuration)
 * List handling (used by shadowing configuration)

Both:
 * Query handling (both POST and GET should work)
 * Static file serving (e.g. CSS)
 * Escaping of data in templates
Comment 30 Niko Lehto cendio 2020-10-12 14:18:50 CEST 
(In reply to Pierre Ossman from comment #25)
> Web Access:
> 
>  * Login form in web access
>  * Session handling
>  * VNC page (including error handling for people loading page directly)
>  * New URLs, and redirection for old URLs
> 
> tlwebadm:
> 
>  * JavaScript loading (used by profile configuration)
>  * Translation handling (used by profile configuration)
>  * List handling (used by shadowing configuration)
> 
> Both:
>  * Query handling (both POST and GET should work)
>  * Static file serving (e.g. CSS)
Looked into these and they work fine. (Tested on Firefox 81)

This howeverdoes not work in all cases (tested in tlwebadm):
>  * Escaping of data in templates
Tested on 4.12 and this is not a regression introduced here. So I opened a new bug for this: Bug 7567
Note You need to log in before you can comment on or make changes to this bug.