Bug 4999 - clean up websocket request handler further
Summary: clean up websocket request handler further
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.10.0
Assignee: Pierre Ossman
URL:
Keywords: prosaic
Depends on:
Blocks:
 
Reported: 2014-02-21 15:47 CET by Pierre Ossman
Modified: 2019-02-11 14:58 CET (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2014-02-21 15:47:45 CET 
We cleaned up the WebSocketRequestHandler class to behave more like a normal RequestHandler. But it still has a lot of bells and whistles that makes it unnecessarily complex.

We should strip it down so that it provides base functionality, just like other RequestHandler stuff already in Python. Fancy extra features like more advanced logging and recording data could be added in a subclass if it is something upstream really wants. And on that note, it should be derived from BaseHTTPRequestHandler, not SimpleHTTPRequestHandler. Or perhaps a "mixin" design is needed given that the base HTTP request handler class might vary.
Comment 1 Pierre Ossman cendio 2019-01-30 11:07:04 CET 
It has been gradually reduced over the years and finally reduced to a mixin in r33913 for bug 7187 and bug 7289.

Considering this fixed.
Comment 2 Peter Åstrand cendio 2019-02-11 14:58:57 CET 
Code reviewed. No need to test anything.
Note You need to log in before you can comment on or make changes to this bug.