The current VDI implementation is stagnant, unmaintained and untested. It seems unlikely that we will be spending any time on this in future either, since we don't believe it is a viable platform for our target user groups. Perhaps it's time to lay our cards on the table and remove VDI support from ThinLinc
As part of this we should back out the changes done in bug 3041, as well as stop listing "client" versions of Windows as supported RDP servers.
* Remove use of configuration keys in appservergroup.hconf - /appservergroups/rdp/<appgroup>/poolname - /appservergroups/rdp/<appgroup>/managed_virtual * Remove use of /vdi/ configuration keys (vdi.hconf) * Remove tl-vdi-tool * Remove tl-vdi-physical * Remove vdi stanza in profiles.hconf.in * Remove tl-clone-prep * Remove VDI support in tl-run-rdesktop * Remove VDI from tlwebadm * Remove VDI from documentation
(In reply to comment #2) > * Remove VDI support in tl-run-rdesktop Commit 28403 removes handling of managed_virtual and a rewrite of rdesktop return code handling...
* Remove VDI from build and shipping in tlmisc
(In reply to comment #2) > * Remove vdi stanza in profiles.hconf.in Fixed in commit r28406
(In reply to comment #4) * Remove VDI from build and shipping in tlmisc Fixed in commit r28407
* Update open source licenses
(In reply to comment #2) > * Remove tl-vdi-tool Commit r28408 deletes tlmisc/vdi from source tree.
(In reply to comment #2) > * Remove use of configuration keys in appservergroup.hconf > - /appservergroups/rdp/<appgroup>/poolname > - /appservergroups/rdp/<appgroup>/managed_virtual > Commit 28410 removes VDI stanza and the use of the configuration keys.
* Remove VDI support from tl-run-unixapp In commit 28404 & 28405 the use of managed_virtual/tl-vdi-tool is removed
(In reply to comment #5) > (In reply to comment #2) > > * Remove vdi stanza in profiles.hconf.in > Fixed in commit r28406 Commit r28411 remove the use of stanza in order configuration.
(In reply to comment #3) > (In reply to comment #2) > > * Remove VDI support in tl-run-rdesktop > Commit 28403 removes handling of managed_virtual and a rewrite of rdesktop > return code handling... Verify if we needs to update the progress indications.
* Remove ZSI which is only used by vdi framwork
(In reply to comment #2) > * Remove VDI from tlwebadm Commit 28412 removes build and ship of VDI in tlwebadm and commit 28413 removes the file from source tree.
(In reply to comment #14) > (In reply to comment #2) > > * Remove VDI from tlwebadm > Commit 28412 removes build and ship of VDI in tlwebadm and commit 28413 removes > the file from source tree. Commit 28414 removes unused write() function which was only used by VDI parts removed in previous commits.
(In reply to comment #13) > * Remove ZSI which is only used by vdi framwork Commit r28415 removes ZSI module from build/ship and open source licenses.
(In reply to comment #2) > * Remove VDI from documentation ThinLinc Administators Guide is updated in commit r28416.
(In reply to comment #12) > (In reply to comment #3) > > (In reply to comment #2) > > > * Remove VDI support in tl-run-rdesktop > > Commit 28403 removes handling of managed_virtual and a rewrite of rdesktop > > return code handling... > > Verify if we needs to update the progress indications. Bug 4988 was added to rework the progress bar into something more useful.
(In reply to comment #16) > (In reply to comment #13) > > * Remove ZSI which is only used by vdi framwork > > Commit r28415 removes ZSI module from build/ship and open source licenses. Commit 28419 removes ZSI reference from doc/internal/components.txt
(In reply to comment #6) > (In reply to comment #4) > * Remove VDI from build and shipping in tlmisc > Fixed in commit r28407 Commit 28421 removes missed vdi.hconf from spec file.
(In reply to comment #2) > * Remove tl-clone-prep tlcloneprep was removed from source tree in commit 28426. The build and ship of tlcloneprep was removed on bug #4486 (comment #10)
Autotests fails when testing against removed VDI files.
(In reply to comment #22) > Autotests fails when testing against removed VDI files. Fixed in commit r28439.
tlwebadm is still restarted twice by tl-setup, which was a hack to work around problems caused by VDI support.
(In reply to comment #1) > As part of this we should back out the changes done in bug 3041, as well as > stop listing "client" versions of Windows as supported RDP servers. This is also not fixed.
(In reply to comment #24) > tlwebadm is still restarted twice by tl-setup, which was a hack to work around > problems caused by VDI support. Fixed in commit 28619.
(In reply to comment #25) > (In reply to comment #1) > > As part of this we should back out the changes done in bug 3041, as well as > > stop listing "client" versions of Windows as supported RDP servers. > > This is also not fixed. - Commit 28620 removes novelluser_reconnect from tl-run-rdesktop - Commit 28621 removes novelluser_reconnect from the documentation - Commit 28622 removes novelluser_reconnect from shipped appserver.hconf - Commit 28623 removes novelluser_reconnect from tlwebadm
(In reply to comment #25) > (In reply to comment #1) > > As part of this we should back out the changes done in bug 3041, as well as > > stop listing "client" versions of Windows as supported RDP servers. > > This is also not fixed. Commit 28624 removes the windows client versions from RDP server requirments.
Time for nitpicking. Found a few stray references to VDI/ZSI. > buildtools/bin/copyright-missing:80: -a -not -path './tlmisc/vdi/VimService_services.py' \ > buildtools/bin/copyright-missing:81: -a -not -path './tlmisc/vdi/VimService_services_types.py' \ > buildtools/bin/copyright-missing:92: -a -not -path './tlmisc/ZSI/*' \ > autotests/installedtree/test_installedfiles.py:386: "/opt/thinlinc/modules/ZSI/", > autotests/installedtree/test_installedfiles.py:462: "/opt/thinlinc/modules/ZSI"] tlwebaccess still has some code that claims it's only used by the VDI module. > webaccess/tlwebaccess-369- def write(self, data, response=200, headers={}): > webaccess/tlwebaccess:370: # FIXME: This is only used by the VDI module > webaccess/tlwebaccess-371- self._write(response, headers, data) The appservergroup tlwebadm module checks for presence of poolname, which was only used with VMware VDI. > tladm/modules/thinlinc/tlwebadm/appservers.py:101: poolname = folder.get_string("poolname") > tladm/modules/thinlinc/tlwebadm/appservers.py:102: if poolname: > tladm/modules/thinlinc/tlwebadm/appservers.py-103- # Not editable. > tladm/modules/thinlinc/tlwebadm/appservers.py-104- editable = False > tladm/modules/thinlinc/tlwebadm/appservers.py-105- else: > tladm/modules/thinlinc/tlwebadm/appservers.py-106- editable = True VDI is still mentioned in the white paper, so I am marking the update-whitepaper bug as a dependency for this bug.
(In reply to comment #29) > Time for nitpicking. Found a few stray references to VDI/ZSI. > > > buildtools/bin/copyright-missing:80: -a -not -path './tlmisc/vdi/VimService_services.py' \ > > buildtools/bin/copyright-missing:81: -a -not -path './tlmisc/vdi/VimService_services_types.py' \ > > buildtools/bin/copyright-missing:92: -a -not -path './tlmisc/ZSI/*' \ > Fixed in commit 28703. > > autotests/installedtree/test_installedfiles.py:386: "/opt/thinlinc/modules/ZSI/", > > autotests/installedtree/test_installedfiles.py:462: "/opt/thinlinc/modules/ZSI"] > Fixed in commit 28704. > tlwebaccess still has some code that claims it's only used by the VDI module. > > > webaccess/tlwebaccess-369- def write(self, data, response=200, headers={}): > > webaccess/tlwebaccess:370: # FIXME: This is only used by the VDI module > > webaccess/tlwebaccess-371- self._write(response, headers, data) > This was removed in tlwebadm in commit r28414. Fixed in commit 28705. > The appservergroup tlwebadm module checks for presence of poolname, > which was only used with VMware VDI. > > > tladm/modules/thinlinc/tlwebadm/appservers.py:101: poolname = folder.get_string("poolname") > > tladm/modules/thinlinc/tlwebadm/appservers.py:102: if poolname: > > tladm/modules/thinlinc/tlwebadm/appservers.py-103- # Not editable. > > tladm/modules/thinlinc/tlwebadm/appservers.py-104- editable = False > > tladm/modules/thinlinc/tlwebadm/appservers.py-105- else: > > tladm/modules/thinlinc/tlwebadm/appservers.py-106- editable = True > > Fixed in commit r28706.
> VDI is still mentioned in the white paper, so I am marking the > update-whitepaper bug as a dependency for this bug. Fixed in commit 28707.
(In reply to comment #2) > * Remove tl-vdi-physical vdi-physical is still around.
(In reply to comment #32) > (In reply to comment #2) > > * Remove tl-vdi-physical > > vdi-physical is still around. Fixed in commit 28721.
There's still a page about VDI on the homepage: http://www.cendio.com/products/thinlinc/solutions/technology/vdibroker.xhtml
(In reply to comment #34) > There's still a page about VDI on the homepage: > > http://www.cendio.com/products/thinlinc/solutions/technology/vdibroker.xhtml Fixed in commit 28747.
I can't find anything VDI still in the product. There's some references to VDI left in the news archives on the web, but that's OK with me.
The VMware Horizon View Client for Linux is available in at least Ubuntu 12.04. Starts OK in a TL session, although I do not have a Horizon View server to connect to at this point.
Windows XP screen shot still present.
(In reply to comment #38) > Windows XP screen shot still present. Fixed in commit 28845.
(In reply to comment #39) > (In reply to comment #38) > > Windows XP screen shot still present. > > Fixed in commit 28845. XP screenshot is gone.
There is JavaScript stuff that only VDI used left in tlwebadm.
(In reply to comment #41) > There is JavaScript stuff that only VDI used left in tlwebadm. javscripts removed in commit 28912.
(In reply to comment #42) > (In reply to comment #41) > > There is JavaScript stuff that only VDI used left in tlwebadm. > > javscripts removed in commit 28912. removed references to javascripts from makefile in commit 28915.
(In reply to comment #43) > (In reply to comment #42) > > (In reply to comment #41) > > > There is JavaScript stuff that only VDI used left in tlwebadm. > > > > javscripts removed in commit 28912. > > removed references to javascripts from makefile in commit 28915. Looks OK, couldn't find anything still referencing the javascripts in tlwebadm.
Minor update in 28969: Don't mention Windows XP in tlsnd context.
