The upgrade of gcc (bug 8361) has exposed a latent issue with our usage of ALSA; we're actually requiring a newer version than we think. Since r27650 for bug 4569, we use the function snd_use_case_set() which was added in alsa-lib 1.0.24. What we have in the build system is 1.0.21. The only reason it works is that this function is used in a module, where the linker has to tolerate that some symbols cannot be resolved until runtime.
We might as well upgrade to the latest possible version. This is the version used on the oldest current systems: RHEL 8: 1.2.10 SLES 15: 1.2.10 Ubuntu 22.04: 1.2.6 Debian 11: 1.2.4
Seems to work well after an upgrade. Tested the client on Fedora 42, Windows 11, and macOS 15.4. > MUST: > > * ThinLinc should be built targeting the latest ALSA that is still supported by all major distributions Yup. Debian 11 was unfortunately a bit old, so that set the bar. Should hopefully mean better support for minor distributions, though. > SHOULD: > > * Related audio libraries should also be upgraded Upgraded all the libraries in the audio/ folder.
Tested server build 4030 on RHEL 9 and Debian 11, and client build 3921 on Windows 11, macOS 15.4, and Fedora 42. On Fedora, I tested both ALSA and PulseAudio. Decided to test sound redirection (bug 7216) for this bug. I did not see any issues. > MUST: > * ThinLinc should be built targeting the latest ALSA that is still supported by > all major distributions Indeed, looks like Debian 11 has the oldest version of ALSA, which we now target. > SHOULD: > * Related audio libraries should also be upgraded All audio libraries were upgraded. Commits look good.
