Comments (or empty lines) under a folder in a .hconf file are not removed when the folder is removed. If there, for example, is a number of profiles in the configuration like this: > [/profiles/xfce] > ... > > [/profiles/cinnamon] > > xdg_session=cinnamon > > # I removed the translations > name=Cinnamon desktop > > # > # I changed the default description > # > description=My own description > icon=cinnamon.svg > screenshot=cinnamon-ss.png > cmdline= > testcmd= > description_from_testcmd=false > > [/profiles/mate] > ... And the profile "cinnamon" then is deleted using Web Admin, the configuration looks like this afterwards: > [/profiles/xfce] > ... > > > # I removed the translations > > # > # I changed the default description > # > > [/profiles/mate] > ...
Fixed now. Tested on Fedora 41. After the changes, using the same test-folder structure as in comment #0, the end result is: > [/profiles/xfce] > ... > > [/profiles/mate] > ... Looking at the AC: > MUST > > * Comments within a folder must be deleted when the folder is deleted Yep. > * Empty lines within a folder must be deleted when the folder is deleted Yep > SHOULD > > * Comments directly above another folder should not be removed No, this was not implemented. All comments will be removed until we reach the next section (folder-marker).
As noticed by Alex in bug 8558, comments in hiveconf can start with ";" as well. Such comments are now also removed upon a folder deletion.
