Bug 8543 - Load details in tlctl are no longer relevant
Summary: Load details in tlctl are no longer relevant
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.19.0
Assignee: Pierre Ossman
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks: 4429
  Show dependency treegraph
 
Reported: 2025-03-13 13:29 CET by Pierre Ossman
Modified: 2025-03-26 13:42 CET (History)
1 user (show)

See Also:
Acceptance Criteria:
MUST: * tlctl doesn't rely on any information that will be removed in bug 4429 SHOULD: * tlctl shows all information used for the new load balancing from bug 4429


Attachments

Description Pierre Ossman cendio 2025-03-13 13:29:12 CET
We're simplifying the load balancer in bug 4429, which means there won't be the same kind of load details available. The output from tlctl needs to be updated to reflect that.
Comment 3 Pierre Ossman cendio 2025-03-14 10:37:27 CET
Everything is now updated, but it exposes another issue; we don't make the table wide enough for subcluster titles:

> Subcluster: "...
> ================
> AGENT      USERS
> ================
> foobar      DOWN
> localhost   DOWN
Comment 4 Pierre Ossman cendio 2025-03-14 11:12:59 CET
Moved to bug 8544 as it is not a blocker here.

> MUST:
> 
>  * tlctl doesn't rely on any information that will be removed in bug 4429

Yes, it now only shows the number of ThinLinc users on each agent.

> SHOULD:
> 
>  * tlctl shows all information used for the new load balancing from bug 4429

Yes, see above.
Comment 5 Samuel Mannehed cendio 2025-03-21 15:00:16 CET
Tested build 3953 on Fedora 41. tlctl now only list number of logged-in ThinLinc users for each agent. There is no longer a `tlctl load show` for details of an agent, since all of that information will be obsolete.

I checked the following scenarios:

* single subcluster with multiple agents
* multiple subclusters
* working agent with sessions
* agent that can't be reached (DOWN)
* the "Users" number updates when a new ThinLinc session is created
* the "Users" number updates when a ThinLinc session is terminated

The commits look good. The acceptance criteria are both sane and are fulfilled.

Note You need to log in before you can comment on or make changes to this bug.