Break out from bug 8503.
We had two backport patches that can be removed now that we are upgrading > v3.3.1.
Right now, the latest version of OpenSSL is 3.4.1, and it looks like there are some CVE's fixed, present in v3.3.1 [1]: CVE-2024-12797: Impact summary - TLS and DTLS connections using raw public keys may be vulnerable to man-in-middle attacks when server authentication failure is not detected by clients. CVE-2024-13176: Impact summary - A timing side-channel in ECDSA signature computations could allow recovering the private key by an attacker. However, measuring the timing would require either local access to the signing application or a very fast network connection with low latency. CVE-2024-9143 Impact summary - Out of bound memory writes can lead to an application crash or even a possibility of a remote code execution, however, in all the protocols involving Elliptic Curve Cryptography that we’re aware of, either only “named curves” are supported, or, if explicit curve parameters are supported, they specify an X9.62 encoding of binary (GF(2^m)) curves that can’t represent problematic input values. Thus the likelihood of existence of a vulnerable application is low. CVE-2024-6119 Impact summary - Abnormal termination of an application can a cause a denial of service. CVE-2024-5535 Impact summary - A buffer overread can have a range of potential consequences such as unexpected application beahviour or a crash. In particular this issue could result in up to 255 bytes of arbitrary private data from memory being sent to the peer leading to a loss of confidentiality. However, only applications that directly call the SSL_select_next_proto function with a 0 length list of supported client protocols are affected by this issue. This would normally never be a valid scenario and is typically not under attacker control but may occur by accident in the case of a configuration or programming error in the calling application. [1] https://openssl-library.org/news/vulnerabilities-3.3/index.html
It doesn't seem like any of the CVEs affect ThinLinc. > CVE-2024-12797 > CVE-2024-6119 > CVE-2024-5535 We don't use OpenSSL for TLS. > CVE-2024-13176 Unclear if it only affects servers (which we don't use OpenSSL for). We do use ECDSA in OpenSSH. Upstream considers this to only be exploitable over a local connection. It's probably not relevant for us. > CVE-2024-9143 Not possible to exploit in real applications according to upstream.
Works well. Tested the client on Fedora 41, and it could communicate properly with RHEL 9 and RHEL 10. > MUST: > > * OpenSSL included in ThinLinc should not have any known security issues affecting ThinLinc users Yup. > SHOULD: > > * The latest stable OpenSSL should be included in ThinLinc Yup.
Tested server build #3940 on RHEL 9, and client build #3831 on Fedora 40, macOS 15, Windows 10, as part of bug 7233 and bug 7222. Did not see any issues. > MUST: > * OpenSSL included in ThinLinc should not have any known security issues > affecting ThinLinc users Indeed. > SHOULD: > * The latest stable OpenSSL should be included in ThinLinc Yes. Commit looks good!
