Bug 8434 - Traceback when trying to add new parameter from tl-config without sudo
Summary: Traceback when trying to add new parameter from tl-config without sudo
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-18 16:30 CEST by Samuel Mannehed
Modified: 2024-10-22 13:39 CEST (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Samuel Mannehed cendio 2024-10-18 16:30:42 CEST 
tl-config needs root permissions for changing parameter values, this is conveyed somewhat clearly:

> $ tl-config /vsmserver/allowed_groups=hej
> Failed to set parameter /vsmserver/allowed_groups

However, when trying to create a new parameter without sudo, we get a traceback:

> $ tl-config /vsmserver/newparameter=0
> Traceback (most recent call last):
>  File "/opt/thinlinc/bin/../bin/hivetool", line 605, in <module>
>    main()
>  File "/opt/thinlinc/bin/../bin/hivetool", line 587, in main
>    errors += handle_param(hive, param)
>              ^^^^^^^^^^^^^^^^^^^^^^^^^
>  File "/opt/thinlinc/bin/../bin/hivetool", line 80, in handle_param
>    if not method(parampath, input_value):
>           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  File "/opt/thinlinc/modules/thinlinc/hiveconf.py", line 527, in set_string
>    return self._set_value(parampath, value, Parameter.set_string)
>           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  File "/opt/thinlinc/modules/thinlinc/hiveconf.py", line 514, in _set_value
>    param = Parameter(None, folder.write_target,
>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  File "/opt/thinlinc/modules/thinlinc/hiveconf.py", line 163, in __init__
>    raise Error("Empty source file!")
> thinlinc.hiveconf.Error: Empty source file!
Note You need to log in before you can comment on or make changes to this bug.