Bug 8281 - Our OpenSSH is out of date
Summary: Our OpenSSH is out of date
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.16.0
Assignee: Pierre Ossman
URL:
Keywords: adaha_tester, prosaic
Depends on:
Blocks:
 
Reported: 2024-01-03 11:13 CET by Pierre Ossman
Modified: 2024-01-08 12:55 CET (History)
2 users (show)

See Also:
Acceptance Criteria:
MUST: * OpenSSH included in ThinLinc should not have any known security issues affecting ThinLinc users SHOULD: * The latest stable OpenSSH should be included in ThinLinc


Attachments

Description Pierre Ossman cendio 2024-01-03 11:13:05 CET
We currently have OpenSSH 9.0p1 in ThinLinc. The latest stable version is 9.6p1, and there have been some security fixes since our last upgrade. Some of those fixes might be relevant for us.
Comment 1 Pierre Ossman cendio 2024-01-03 11:33:34 CET
There doesn't seem to be anything relevant for us since our last upgrade. But it's probably best to stay in sync anyway:

9.2p1 fixed an issue in the SOCKS proxy, something we do not use.

9.2p1 also fixed issues with the hostname canonicalization, which we also do not use.

9.3p1 fixes an issue with getting host keys via DNS, a feature we do not support (bug 4706).

9.5p1 adds extra protection to make it difficult to detect keystrokes. It doesn't look like it will affect us, though, as it seems to only be for the normal TTY channel.

9.6p1 fixes a security issue that only seems to affect the above mentioned keystrokes obfuscation.

9.6p1 also has some fixes when ssh runs external commands, something we do not use.
Comment 8 Adam Halim cendio 2024-01-04 16:19:52 CET
Tested client build 3369 on Windows 10 & 11, macOS (x86 & arm) and Fedora 38 on a server running  build 3471 on Fedora 38:

  Authentication | Win64 | macOS | Fedora 38 |
 ----------------+-------+-------+-----------+
   Kerberos      |   X   |   X   |     X     |
 ----------------+-------+-------+-----------+
   Smart card    |   X   |   X   |     X     |
 ----------------+-------+-------+-----------+
   SSH key       |   X   |   X   |     X     |
 ----------------+-------+-------+-----------+
   Password      |   X   |   X   |     X     |

Also tested client build 3369 on Fedora 38 on a server running build 3471 on SLES 12:

  Authentication | Fedora 38 |
 ----------------+-----------+
   Kerberos      |     *     |
 ----------------+-----------+
   Smart card    |     X     |
 ----------------+-----------+
   SSH key       |     X     |
 ----------------+-----------+
   Password      |     X     |

* Didn't manage to set up Kerberos properly on SLES 12.

Everything working as expected.
Comment 9 Pierre Ossman cendio 2024-01-04 16:25:13 CET
I also tested sound redirection from a Fedora 38 client to a Fedora 39 server.
Comment 10 Pierre Ossman cendio 2024-01-04 16:26:34 CET
I can't see anything in OpenSSH's release notes that will be noticable by our users, so I'll omit release notes for this bug.
Comment 11 Pierre Ossman cendio 2024-01-04 16:30:18 CET
Everything should now be upgraded and working well:

> MUST:
> 
>  * OpenSSH included in ThinLinc should not have any known security issues
>    affecting ThinLinc users
> 

We did not find anything relevant among the OpenSSH release notes.

> SHOULD:
> 
>  * The latest stable OpenSSH should be included in ThinLinc

Yup, we're now using the latest version. This can be confirmed in the client log files.
Comment 12 Alexander Zeijlon cendio 2024-01-08 11:07:21 CET
I also tested that local drives work as expected. Client running on Fedora 39 and server running on RHEL 8.
Comment 13 Alexander Zeijlon cendio 2024-01-08 12:55:31 CET
Verify:
#######

> MUST:
> * OpenSSH included in ThinLinc should not have any known security
>   issues affecting ThinLinc users
✅ There is one known vulnerability, CVE-2023-51767, which affects versions through 9.6p1. But the components reported as vulnerable are not used in tlclient.

> SHOULD:
> * The latest stable OpenSSH should be included in ThinLinc
✅ Running tlclient in debug mode results in the following line in tlclient.log:
> 2024-01-05T13:18:39: ssh[E]: OpenSSH_9.6p1, OpenSSL 3.2.0 23 Nov 2023

We also looked through the commits that relate to signal handling on Windows, and they all look good, and were tested as of comment 8.

Closing!

Note You need to log in before you can comment on or make changes to this bug.