Bug 8268 - Timeouts in vsmserver and vsmagent if DNS is slow
Summary: Timeouts in vsmserver and vsmagent if DNS is slow
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
Depends on:
Reported: 2023-12-07 16:54 CET by Pierre Ossman
Modified: 2023-12-12 13:18 CET (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Pierre Ossman cendio 2023-12-07 16:54:31 CET
vsmserver and vsmagent have a list of approved hosts that are allowed to communicate with them. To respect DNS changes to these hosts, we look up the hosts on each connection.

Normally, a bit of delay shouldn't be a problem, as we generally have a timeout of 40 seconds for XML-RPC requests. The issue is that the DNS requests are synchronous, so the delays accumulate. Every XML-RPC request will have to wait for the DNS lookup for all requests before it. But the timeouts still keep ticking. So it doesn't require that many requests until things start failing.

The issue could also affect many other things as everything in the respective service gets paused and delayed.
Comment 1 Pierre Ossman cendio 2023-12-07 16:57:02 CET
When we wrote this code, there weren't any good asynchronous versions available. But now that we've switched to asyncio, there is one available:


Note that the caller of the relevant code also expects a synchronous result, so some redesign of this entire section of code will be needed.

Note You need to log in before you can comment on or make changes to this bug.