Bug 8255 - vsmserver/vsmagent XML-RPC handlers don't handle cancelled requests
Summary: vsmserver/vsmagent XML-RPC handlers don't handle cancelled requests
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-13 16:55 CET by Pierre Ossman
Modified: 2023-11-14 13:14 CET (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2023-11-13 16:55:53 CET 
When vsmserver or vsmagent services an XML-RPC request, that request will always be fully processed, even if the request gets cancelled (because the connection was dropped).

This is not ideal for two reasons:

 * We waste resources continuing to handle something that the caller won't see the result of

 * Things could possibly get out of sync as the caller won't know whether the call succeeded or not

We would like all handlers to be able to roll back any changes if the request gets cancelled.

(This was an explicitly omitted new feature in the conversion from asyncore to asyncio in bug 8224. The old asyncore code didn't even have the infrastructure for something like this.)
Note You need to log in before you can comment on or make changes to this bug.