Python 3 added the "nonlocal" keyword to control scoping. Unfortunately, our obfuscator isn't aware of this and isn't managed to handle naming properly: RuntimeError: Overlooked symbol 'call' on line 277 column 17
Patch fixed and sent upstream: https://github.com/astrand/pyobfuscate/pull/27
Committed and done. > MUST: > > * nonlocal constructs should work correctly after obfuscation Yup. Works with code in product. > SHOULD: > > * nonlocal variables should be obfuscated They are indeed. > * there should be automatic tests for nonlocal There are. Based roughly on what existing tests we had for local variables and global variables. > * upstream should have a patch Yup. See above.
Tested building server-bundle after upgrading cendio-build-python3-pyobfuscate-x86_64 to version 0.3-7.g6731c8a, and can confirm that nonlocal variable no longer cause the RuntimeError seen in comment 0. MUST: ✅ nonlocal constructs should work correctly after obfuscation They do. Tested by adding a test function that wrote the value of the nonlocal variable in the log. The variable had the expected value. SHOULD: ✅ nonlocal variables should be obfuscated They are. ✅ there should be automatic tests for nonlocal Yes, there are unit tests included in the patch for upstream. ✅ upstream should have a patch Patch is sent as has been applied to the project. Also checked the code changes in our code and for the upstream patch, looks good.
