Bug 8179 - ThinLinc logo in TAG not reflecting the new visual profile
Summary: ThinLinc logo in TAG not reflecting the new visual profile
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Documentation (show other bugs)
Version: trunk
Hardware: Other Other
: P2 Normal
Target Milestone: 4.15.0
Assignee: Tobias
URL:
Keywords: ossman_tester, relnotes
Depends on:
Blocks: 7910
  Show dependency treegraph
 
Reported: 2023-06-30 16:31 CEST by Tobias
Modified: 2023-07-10 16:44 CEST (History)
0 users

See Also:
Acceptance Criteria:
Must: * Independent instances of the ThinLinc logo must reflect the new visual profile Should: * Screenshots containing the ThinLinc logo should reflect the new visual profile * Updated images should look sharp when scaled


Attachments

Description Tobias cendio 2023-06-30 16:31:56 CEST
There seems to be at least two places in the TAG where the ThinLinc icon is displayed, namely on the front page and on the Client Usage page -- the last one displaying an image of the native client.

We should update all instances of the ThinLinc icon in the TAG to reflect the new visual profile with the updated icon.
Comment 2 Tobias cendio 2023-07-03 13:50:12 CEST
Updated the front page ThinLinc logo for html and pdf versions -- both of which now display a scalable SVG version.

Confirmed good quality in the largest browsers; Chrome, Firefox, Edge, and Safari, on Fedora38, Win10, and macOS13.

Acceptance criteria:
Must:
--------------
✅ Independent instances of the ThinLinc logo must reflect the new visual profile

Only the front page qualifies, which has been updated.

Should:
--------------
❌ Screenshots containing the ThinLinc logo should reflect the new visual profile

This was deemed to be beyond the scope since it preferably involves updating all the native client screenshots -- not solely the main one with the logo. Will be done within the confines of a separate bug.

✅ Updated images should look sharp when scaled

The updated images are of SVG format and look sharp when zoomed.
Comment 3 Pierre Ossman cendio 2023-07-03 16:04:17 CEST
The new logo looks good. Works well in the web browser, even with scaling.

PDF also works well. Scales and renders correctly. Tried Firefox, Evince and an actual print.

Two minor notes, though:

 * Should be more padding around the logo. Our guidelines state it should be empty space around the logo equal to half the height of the logo.

 * It looks a bit odd when it is centred above text that is aligned to the left. Not a new issue, though.
Comment 6 Tobias cendio 2023-07-04 12:50:06 CEST
The issues in comment 3 have been addressed.
Comment 7 Pierre Ossman cendio 2023-07-05 09:39:10 CEST
Adjustments to logo positioning looks good.

Everything seems done as far as I can see:

> Must:
> * Independent instances of the ThinLinc logo must reflect the new visual profile

I could not find any instances of the old ThinLinc logo, except the client screenshots.

> Should:
> * Screenshots containing the ThinLinc logo should reflect the new visual profile

Ignored.

> * Updated images should look sharp when scaled

Looks good, as mentioned in comment #3.
Comment 8 Pierre Ossman cendio 2023-07-06 16:58:21 CEST
Upon closer inspection, it turns out that this is not the correct logo. It does not include the white portions properly. It is unclear where this logo comes from as no such logo should exist.
Comment 11 Tobias cendio 2023-07-07 12:19:30 CEST
The issue mentioned in comment 8 has been addressed. In addition, we now refer to a common image file for all products, so that we avoid having to maintain several identical images.

Had a look at the rendering of both the HTML and PDF versions in Firefox, Chrome, and Evince, which look perfectly fine.
Comment 13 Pierre Ossman cendio 2023-07-10 10:17:54 CEST
Retested and logo looks good¹ in both HTML and PDF version in Firefox, Chrome and Evince. Print also looks correct as far as I can see.

There is no checked in version of the logo in doc/external any more, so there should also be no risk of divergence.

¹ Except for the known non-integer scaling bug where there is a thin blue line visible next to the white section

Note You need to log in before you can comment on or make changes to this bug.