Bug 8169 - Remote resize active for shadowers (regression)
Summary: Remote resize active for shadowers (regression)
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Samuel Mannehed
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks:
 
Reported: 2023-06-13 13:52 CEST by Pierre Ossman
Modified: 2023-07-26 09:57 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:
MUST: * When a shadower resizes his/her window, the session must not be resized. * When a session owner resizes his/her window, the session must be resized. COULD: * The shadow-resize behavior could be enforced on the server side.


Attachments

Description Pierre Ossman cendio 2023-06-13 13:52:10 CEST
We accidentally undid bug 4479 when fixing bug 7793, specifically in r37660.

When shadowing, the shadower should be considered a lower priority user than the owner of the session. So we should continue respecting the display configuration of the session owner.
Comment 1 Pierre Ossman cendio 2023-06-13 13:53:19 CEST
Should we prevent this on the server instead of having a client setting? That would be more robust enforcement of this behaviour. It would limit us if we want to make this a user/shadower choice in the future, though.
Comment 3 Samuel Mannehed cendio 2023-07-26 09:57:51 CEST
This has been fixed now. I verified build 3235 on Fedora 38, Windows 11 and macOS 13.

> MUST:
> 
> * When a shadower resizes his/her window, the session must not be resized.
> 
> * When a session owner resizes his/her window, the session must be resized.

Yep, verified the following scenarios on all 3 native client platforms:

 ✓ Using native client, session owner resizes his window. The session resizes to follow the window size, making it both larger and smaller.
 ✓ Using Web Access, session owner resizes his window. The session resizes to follow the window size, making it both larger and smaller.
 ✓ Shadower connects to session owned by user on native client. He resizes his window, but the session doesn't resize.
 ✓ Shadower connects to session owned by user on Web Access. He resizes his window, but the session doesn't resize.

> COULD:
> 
> * The shadow-resize behavior could be enforced on the server side.

Due to time constraints, this was not prioritized. A FIXME was committed in the code.

Note You need to log in before you can comment on or make changes to this bug.