Bug 8149 - tlwebadm TAG screenshots not reflecting new visual profile
Summary: tlwebadm TAG screenshots not reflecting new visual profile
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: trunk
Hardware: Other Other
: P2 Normal
Target Milestone: 4.15.0
Assignee: Tobias
URL:
Keywords: linma_tester, prosaic, samuel_tester
Depends on:
Blocks: 7909
  Show dependency treegraph
 
Reported: 2023-05-09 11:14 CEST by Tobias
Modified: 2023-07-21 17:35 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:
Must ========== * Update existing screenshots to reflect tlwebadm new visual changes * Screenshots should be sharp when zoomed Could ========== * Hide background content in popup screenshots


Attachments

Description Tobias cendio 2023-05-09 11:14:00 CEST
Apart from the primary issue, the sections currently lacking screenshots should be reevaluated whether they should have a corresponding screenshot or not.
Comment 2 Samuel Mannehed cendio 2023-05-10 16:44:34 CEST
> Should
> ==========
> * Add screenshots to pages currently lacking
>   - Remaining pages

This was moved to bug 8151.
Comment 5 Tobias cendio 2023-05-11 15:51:39 CEST
tlwebadm screenshots have been updated from PNGs to scalable SVGs, reflecting the new visual profile.
Comment 6 Linn cendio 2023-05-12 11:36:23 CEST
Tested the acceptance criteria, and both criteria under Must and Should have been fulfilled. Compared to the TAG for 4.14.0 to see that the screenshots still had the same content.

> Must
> ==========
> * Update existing screenshots to reflect tlwebadm new visual changes
> * Screenshots should be sharp when zoomed
I checked these chapters in the TAG for screenshots:
 1) Administration of ThinLinc using the Web Administration Interface
 2) Building custom Linux desktops with the ThinLinc Desktop Customizer

I only found screenshots in 1) under the VSM Module and Locations Module. The screenshots had been updated and looked sharp even when zooming to 200%.


> Could
> ==========
> * Hide background content in popup screenshots
Screenshots only containing a popup have no background, tested by changing the colour of the HTML element behind the screenshot and could see that the image had no outline outside of the popup window.


Also checked the commits, old files have been cleaned away and changes look appropriate.
Comment 7 Tobias cendio 2023-05-16 09:42:16 CEST
Reopening to fix clip and mask problems that emerged in the PDF version.
Comment 10 Tobias cendio 2023-05-17 12:53:04 CEST
The SVG screenshots should be fine now both in HTML and PDF renderers.
Comment 12 Samuel Mannehed cendio 2023-05-19 17:09:25 CEST
The updated screenshots look good in both HTML and PDF format, tested Firefox, Chrome, and Epiphany on Fedora 38.

The README in doc/external/images/ is helpful, and the new additions are nice. Closing.

Note You need to log in before you can comment on or make changes to this bug.