Bug 8136 - Web Admin pop-ups don't fade out after "Save" or "Delete"
Summary: Web Admin pop-ups don't fade out after "Save" or "Delete"
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-06 16:18 CEST by Samuel Mannehed
Modified: 2023-05-02 11:33 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments

Description Samuel Mannehed cendio 2023-04-06 16:18:46 CEST
Pop-ups are used in Web Admin to display item details of different kinds. Animations are used to nicely fade in the popup when opened, and fade out when closed.

The fade out animation doesn't play after pressing “Save”, “Delete” or “Terminate” (for sessions). Currently, it only fades out after pressing the “X” to close the popup.

Technically, it is quite difficult to resolve this at the moment. The issue is that Web Admin relies heavily on navigating between different pages and POSTing data after actions. The actions “Save”, “Delete” or “Terminate” are all submits, and the parameters determining if the popup should close or stay open are all set by the python backend. We can't start a fade out when pressing, for example, “Save” since we don't know at that point if the pop-up should close or not. Once the frontend receives a page to display, it no longer has access to the old one to ensure a nice animated transition.
Comment 1 Alexander Zeijlon cendio 2023-04-12 13:49:03 CEST
Additionally, there is no fade in animation on some pages when buttons on the main page for adding new entries are clicked.

> |Button               |Animation|
> |"Add new subcluster" |Yes      |
> |"Add new profile"    |No       |
> |"Add new location"   |No       |
> |"Add new terminal"   |No       |
> |"Add new group"      |Yes      |
> |"Add new application"|No       |
> |"Add new menu"       |No       |
Comment 2 Samuel Mannehed cendio 2023-04-19 13:50:24 CEST
(In reply to Alexander Zeijlon from comment #1)
> Additionally, there is no fade in animation on some pages when buttons on
> the main page for adding new entries are clicked.
> 
> > |Button               |Animation|
> > |"Add new subcluster" |Yes      |
> > |"Add new profile"    |No       |
> > |"Add new location"   |No       |
> > |"Add new terminal"   |No       |
> > |"Add new group"      |Yes      |
> > |"Add new application"|No       |
> > |"Add new menu"       |No       |

This has now been fixed as part of bug 8075.
Comment 3 Samuel Mannehed cendio 2023-05-02 11:33:32 CEST
Currently, our code detects if a fade-in animation should be shown by checking if "details" are part of the query in the URL. This mechanism locks us to providing "details" in the query on all pages here. It should be noted that this is quite magical and not very robust.

Note You need to log in before you can comment on or make changes to this bug.