Bug 8135 - Inconsistent usage of normal messages when actions are taken in tlwebadm
Summary: Inconsistent usage of normal messages when actions are taken in tlwebadm
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: trunk
Hardware: Other Other
: P2 Normal
Target Milestone: MediumPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-05 16:17 CEST by Alexander Zeijlon
Modified: 2023-04-11 13:14 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Pop-up as a notification (14.90 KB, image/png)
2023-04-05 16:17 CEST, Alexander Zeijlon 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Alexander Zeijlon cendio 2023-04-05 16:17:24 CEST 
Created attachment 1116 [details]
Pop-up as a notification

In tlwebadm we have the ability to add a notification-like message to the top of the page when settings are saved/stored in the backend. These messages are not used consistently when actions are taken that cause configurations to change.

One example of this is when editing profiles:
- Creating a profile results in a notification.
- Editing an already existing profile results in a notification.
- Deleting a profile does *not* result in a notification.

Another example is that in Status⇾Sessions, we notify users that a session has been terminated in a pop-up instead.
Comment 1 Linn cendio 2023-04-11 11:03:04 CEST 
Through commit r40048, the termination message on the session page is now shown on the "top-level" of the page instead of in the pop-up, to conform more to the general message formatting we use.

I checked that the message on the session page conformed reasonable with the other messages we have - placed straight under the title of the page, uses the message style formatting and can be used as an anchor.

I think it would be suitable to give the termination message another look in this bug, to make sure that message fully conforms with the other ones.
Comment 2 Samuel Mannehed cendio 2023-04-11 13:05:53 CEST 
Another issue we should consider when fixing this is that these messages dont work the same way the popup messages in Web Access do. Those messages appear fixed at the top, and on top of other content, and have a timeout to disappear automatically.
Note You need to log in before you can comment on or make changes to this bug.