Created attachment 1107 [details] Names with spaces In Web Admin ⇒ Desktop customizer ⇒ Application Groups, groups can be added that only have spaces as a name. This results in table rows on the page that are not clickable, which means that the popup for those groups can not be opened. (The popup can be opened by inspecting and then following the link in the href property.) Another effect of allowing leading and trailing spaces in names is that we can have multiple groups with similar looking names, f.ex. "Games" and "Games ".
In VSM ⇒ Subclusters, when adding a new sub cluster, all spaces in the name are converted to underscores when you save. You can also bypass the error message that a sub cluster needs at least one agent by also adding a space there, that space is gone after saving, and you end up with a sub cluster without agents.
In VSM ⇒ Agent, you can set Agent hostname to a space, which makes no sense.
In Profiles ⇒ Profile list, you can set a profile's default name to a space, which makes it impossible to click on it in the table of profiles.
In Locations ⇒ Locations, you can set a location's name to a space, which makes it impossible to click on it in the table of locations.
In Locations ⇒ Terminals, you can set a terminal's name to a space, which makes it impossible to click on it in the table of terminals. Note that it was possible to select the location created in comment 4 as a location for terminals.
In Desktop Customizer ⇒ Applications (Manual), you can set an application's name to a space, which makes it impossible to click on it in the table on that page.
In Desktop Customizer ⇒ Menu Structure, you can set a menu's name to a space, which makes it impossible to click on it in the table on that page.
Pages no longer allow for empty table item names -- neither of zero length nor space-only names. No changes have been made to the subcluster page which still doesn't accept names of zero length, but does accept space-only names. However, this doesn't cause a problem since underscores are imposed in place of spaces for all subcluster names. Why this page in particular exhibits this unique behavior is beyond the scope of this bug. Moreover, on the Profiles/Introduction Texts page, it's possible to leave the language column empty when adding a new translation. However, this item can still be deleted and remade, so it's not as broken.
This is indeed fixed now. Tested all mentioned pages for both empty names and space-only names. > It should be impossible to > > * Add new table items with empty names It is > * Add new table items with space-only names It is * > * Rename existing table items to empty names It is > * Rename existing table items to space-only names It is * * Except subcluster, as described in comment #11
It should be noted that, concerning profile list table items, it was previously permitted to use empty default names since the identification acted as a fallback. However, this was buggy and did not take effect immediately when exiting the detailed view, but rather when reloading the page once more. Disallowing empty default names was an easy solution to this and added to the consistency across pages regarding empty names.
(In reply to Tobias from comment #13) Old configurations are not inhibited in any way -- it's only when actively saving an empty default profile name one gets an error.
