Bug 8106 - Saving with empty application group name crashes Web Admin
Summary: Saving with empty application group name crashes Web Admin
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: TLDC (Desktop Customizer) (show other bugs)
Version: 4.14.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Tobias
URL:
Keywords: aleze_tester, prosaic
Depends on:
Blocks:
 
Reported: 2023-02-28 10:00 CET by Frida Flodin
Modified: 2023-03-07 14:41 CET (History)
2 users (show)

See Also:
Acceptance Criteria:
The appgroup name should successfully save when: * Adding a new appgroup with non-empty name * Changing an existing appgroup name to a non-empty name The page should not crash, but rather display an error in the GUI when: * Adding a new appgroup with empty name * Changing an existing appgroup name to an empty name

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Frida Flodin cendio 2023-02-28 10:00:54 CET 
When trying to save an application group with empty name the page crashes with the following:


> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1] ----------------------------------------
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1] Exception happened during processing of request from ('::1', 58484, 0, 0)
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1] Traceback (most recent call last):
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/forkingserver.py", line 62, in process_request
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     self . finish_request ( request , client_address )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/httpserver.py", line 407, in finish_request
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     super ( ) . finish_request ( request , client_address )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/tlstunnel.py", line 71, in finish_request
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     self . TLSRequestHandlerClass ( request , client_address , self )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/httpserver.py", line 78, in __init__
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     super ( ) . __init__ ( request , client_address , server )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/usr/lib64/python3.10/socketserver.py", line 747, in __init__
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     self.handle()
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/httpserver.py", line 380, in handle
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     super ( ) . handle ( )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/usr/lib64/python3.10/http/server.py", line 433, in handle
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     self.handle_one_request()
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/httpserver.py", line 155, in handle_one_request
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     super ( ) . handle_one_request ( )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/usr/lib64/python3.10/http/server.py", line 421, in handle_one_request
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     method()
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/tlwebadm/server.py", line 221, in do_POST
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     self . post_or_get ( "do_POST" , II1iiii )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/tlwebadm/server.py", line 175, in post_or_get
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     OooO0O00o0 , OOo = getattr ( IIiII11I , action ) ( I11ii1IiIii , query , OooO0O00o0 )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/tlwebadm/main.py", line 145, in do_POST
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     self . _POST_METHODS . get ( page_name , self . error_404 ) ( query ) )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/tlwebadm/desktop.py", line 226, in appgroups
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     i1iiiiIIIiIi [ 'errors' ] = self . _save_group ( query , oooOo )
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]   File "/opt/thinlinc/modules/thinlinc/tlwebadm/desktop.py", line 459, in _save_group
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1]     Ooo = query [ "appgroup_name" ] [ 0 ]
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1] KeyError: 'appgroup_name'
> 2023-02-28 09:40:36 ERROR tlwebadm[2044753]: [::1] ----------------------------------------
Comment 1 Tobias cendio 2023-03-02 12:50:57 CET 
While resolving save errors in bug 8075, this bug was in the way. Fixing now is appropriate.
Comment 3 Tobias cendio 2023-03-02 14:03:34 CET 
This is fixed now.
Comment 5 Alexander Zeijlon cendio 2023-03-07 12:48:24 CET 
Verified & Tested that the issue has been resolved by comment 2.

The appgroup name should successfully save when:
> * Adding a new appgroup with non-empty name
Works!

> * Changing an existing appgroup name to a non-empty name
Works!

The page should not crash and display an error in the GUI when:
> * Adding a new appgroup with empty name
Works!

> * Changing an existing appgroup name to an empty name
Works!
Note You need to log in before you can comment on or make changes to this bug.