Comment 2 Samuel Mannehed 2024-10-22 17:15:42 CEST

> MUST:
> * The user must be able to get an overview of at least 10 agents/users/groups

✓ Yes, this is easier.

These are now presented in textareas, with one row per agent/user/group (up to a limit).

> SHOULD:
> * It should be possible to have an overview of at least 10 agents/users/groups while adding/removing/editing

✓ Yes, this is easier.

All spaces are automatically converted to new lines in the textareas. This makes it much easier to work with multiple entries.

> * The new subcluster configuration interface should follow the style of other parts of Web Admin

✗ No, a new type of interface was added for this.

The type of element used for, for example, allowed_shadowers is quite complex. It also involves input validation (through tlwa_types). Taking that route for this bug didn't seem necessary. The downside with the approach in commit r41263 is that the user might have to get used to a new type of interface. I believe it's worth it though, and I hope the new interface feels simple enough.

> COULD:
> * The user could be able to import a list of agents/users/groups from an external CSV file or similar.

✗ No, this wasn't implemented.

Comment 3 Samuel Mannehed 2024-10-22 17:31:58 CEST

Note that the subcluster-popup screenshot in the TAG will be updated as part of bug 284 which also modified its contents.

Comment 5 Samuel Mannehed 2024-10-22 19:24:46 CEST

A system test (installedtree/test_templates.py) started failing due to r41263.

Comment 6 Samuel Mannehed 2024-10-22 19:24:58 CEST

It was fixed in r41265.

Comment 7 Tobias 2024-10-28 12:45:23 CET

General
-------------------
Tested this bug using server build #3758 with a combination of OS/browsers:

Fedora 40
    Firefox 131
    Chromium 130
macOS 14.5
    Firefox 131
    Safari 17.5
iOS 15.8
    Safari
Win11 64bit
    Edge 130
    Firefox 131
    Chrome 130

The new input functionality seems to be working as intended. Only one element
per row is being displayed now, with new rows automatically structured if spaces
and/or newlines are inserted.

Long element names can potentially be misinterpreted as several elements, due to
the way text is wrapped according to the textarea width. However, the potential
name lengths are quite high, so this is probably a rare problem.

Element overview is greatly improved, where one can now view roughly 13 elements
simultaneously, before scrolling is enforced. If element names are very long
though, as mentioned in above, fewer elements are displayed.

Tabs don't introduce any inconveniences nor grossly unpredictable
behavior. While they appear to be registered in the conf when entered manually
or via tl-config, they are not loaded into the textareas in tlwebadm. However,
if entered manually in tlwebadm, they are stored in the conf. Once tlwebadm is
reloaded though they disappear, and followed by a subcluster Save they're also
gone in the conf.

Acceptance criteria
-------------------
MUST:
✅ The user must be able to get an overview of at least 10 agents/users/groups

   Check.

SHOULD:
✅ It should be possible to have an overview of at least 10 agents/users/groups
   while adding/removing/editing

   Check.

❌ The new subcluster configuration interface should follow the style of other
   parts of Web Admin

   Wasn't attempted.

COULD:
❌ The user could be able to import a list of agents/users/groups from an
   external CSV file or similar.

   Wasn't attempted.

Conclusion
-------------------

After the changes introduced in this bug, it is no longer cumbersome to edit
large subcluster configurations.

Closing.