Bug 8071 - Remove unnecessary "Home" from sub menu in Web Admin
Summary: Remove unnecessary "Home" from sub menu in Web Admin
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Linn
URL:
Keywords: frifl_tester, prosaic
Depends on:
Blocks:
 
Reported: 2023-01-13 15:39 CET by Linn
Modified: 2023-01-18 09:37 CET (History)
1 user (show)

See Also:
Acceptance Criteria:
* No submenu in Web Admin should include the "Home" item. * If unused, "Home" should be cleaned up from the corresponding Python code.


Attachments

Description Linn cendio 2023-01-13 15:39:21 CET
In the side menu in Web Admin, all top-level menu items have a submenu containing the item "Home", even if this is the only item in the sub menu. Having a submenu only for one item is a bit redundant, and even for submenus with several items, "Home" can be reached by clicking the top-level item. Let's remove sub menu item "Home" fully.

Note that we use Cheetah to create the menu structure, which makes use of variables from our Python code. These variables should also get a check to see if something can be cleaned up from them.
Comment 3 Linn cendio 2023-01-16 12:41:16 CET
Tested and things look fine.

> * No submenu in Web Admin should include the "Home" item.
Checked Webadmin webpage and the resulting html, subpage "Home" is no longer shown.


> * If unused, "Home" should be cleaned up from the corresponding Python code.
Regarding the variables in Python, the way the code is structured assumes there must be at least one subpage per top-level item. "Home" also works as a good indicator for what current page we are on. No cleaning done.
Comment 4 Frida Flodin cendio 2023-01-18 09:37:01 CET
This looks good! 
> * No submenu in Web Admin should include the "Home" item.
There is no longer any "Home" submenus

> * If unused, "Home" should be cleaned up from the corresponding Python code.
We still use "Home" as an indicator of the current page. So, it's reasonable to keep that variable.

Note You need to log in before you can comment on or make changes to this bug.