Bug 8029 - Should not include default message to Python send_error()
Summary: Should not include default message to Python send_error()
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
Depends on:
Reported: 2022-11-16 15:03 CET by Pierre Ossman
Modified: 2022-11-22 12:40 CET (History)
0 users

See Also:
Acceptance Criteria:


Description Pierre Ossman cendio 2022-11-16 15:03:07 CET
Python's BaseHTTPRequestHandler.send_error() is used when you want to report an HTTP error back to the browser. It takes an HTTP error code, and optional description text.

It has a table of default descriptions for all well-known codes. Hence, we shouldn't be duplicating those, as we're just likely to have worse or unfamiliar versions. Unfortunately, that is the case in some parts of the code.

An exception is when we can provide more details. E.g., for code 400 we might be able to be more specific about what in the request is incorrect.
Comment 1 Pierre Ossman cendio 2022-11-16 15:24:54 CET
The current offenders are:

* thinlinc.tlwebadm.server (gray area)
* thinlinc.httpserver
* thinlinc.tlwebaccess.server

Note You need to log in before you can comment on or make changes to this bug.