When writing out the version in Web Access and in our Web Administration, we currently write something like this: > Version 4.14.0 (build 2408) on tl.cendio.se The last part where we write the hostname seems quite unnecessary, since that information will be available in the address bar of the browser anyway.
The $hostname is no longer shown in the Web Access frontend, and is gone from the backend. Removing it from Web Admin remains. This is the reason a tlwebadm unit test is currently failing (test_templates.TemplateTests.test_escaping): > Traceback (most recent call last): > File "/usr/lib/python3.6/unittest/case.py", line 59, in testPartExecutor > yield > File "/usr/lib/python3.6/unittest/case.py", line 605, in run > testMethod() > File > "/var/lib/jenkins/jobs/thinlinc_server/workspace/autotests/installedtree/test_templates.py", line 160, in test_escaping > self.fail("Unescaped variables in: %s" % ",\n ".join(bad)) > File "/usr/lib/python3.6/unittest/case.py", line 670, in fail > raise self.failureException(msg) > AssertionError: Unescaped variables in: /opt/thinlinc/share/tlwebadm/templates/main.tmpl ($hostname)
Note that the help function cannot be fully removed from tlwebadm, as it is needed to redirect to tlclient.cgi.
Should be gone from both now.
Looks better, the hostname is removed from both tlwebadm and Web Access.
