Bug 7989 - Unnecessary "hostname" text in webadm and webaccess
Summary: Unnecessary "hostname" text in webadm and webaccess
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Samuel Mannehed
Keywords: frifl_tester, prosaic
Depends on:
Reported: 2022-09-14 09:42 CEST by Samuel Mannehed
Modified: 2022-09-26 10:56 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Samuel Mannehed cendio 2022-09-14 09:42:08 CEST
When writing out the version in Web Access and in our Web Administration, we currently write something like this:

> Version 4.14.0 (build 2408) on tl.cendio.se

The last part where we write the hostname seems quite unnecessary, since that information will be available in the address bar of the browser anyway.
Comment 3 Samuel Mannehed cendio 2022-09-14 13:34:34 CEST
The $hostname is no longer shown in the Web Access frontend, and is gone from the backend.

Removing it from Web Admin remains. This is the reason a tlwebadm unit test is currently failing (test_templates.TemplateTests.test_escaping):

>  Traceback (most recent call last):
>   File "/usr/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
>     yield
>   File "/usr/lib/python3.6/unittest/case.py", line 605, in run
>     testMethod()
>   File > "/var/lib/jenkins/jobs/thinlinc_server/workspace/autotests/installedtree/test_templates.py", line 160, in test_escaping
>     self.fail("Unescaped variables in: %s" % ",\n    ".join(bad))
>   File "/usr/lib/python3.6/unittest/case.py", line 670, in fail
>     raise self.failureException(msg)
> AssertionError: Unescaped variables in: /opt/thinlinc/share/tlwebadm/templates/main.tmpl ($hostname)
Comment 4 Pierre Ossman cendio 2022-09-19 12:22:47 CEST
Note that the help function cannot be fully removed from tlwebadm, as it is needed to redirect to tlclient.cgi.
Comment 6 Pierre Ossman cendio 2022-09-19 13:05:50 CEST
Should be gone from both now.
Comment 7 Frida cendio 2022-09-26 10:56:49 CEST
Looks better, the hostname is removed from both tlwebadm and Web Access.

Note You need to log in before you can comment on or make changes to this bug.