Bug 7985 - Caps lock/Num lock synchronisation doesn't work
Summary: Caps lock/Num lock synchronisation doesn't work
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks: keyboard
  Show dependency treegraph
 
Reported: 2022-08-30 10:08 CEST by Pierre Ossman
Modified: 2022-08-31 11:30 CEST (History)
0 users

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2022-08-30 10:08:17 CEST
ThinLinc 4.10.0 (via bug 400) got support for synchronising the state of the lock keys (caps lock, num lock, scroll lock) between the server and the client. This solves some special corner cases.

Unfortunately, we accidentally broke this in ThinLinc 4.12.0 in bug 7373 when some debug code was accidentally left in.

The upstream commit breaking this is this one:

https://github.com/TigerVNC/tigervnc/commit/81e114f29f007c689a41ca2bb72f314d50898381

Things have mostly worked fine anyway, since it is rare this synchronisation matters. We also added some fallback handling in bug 400 that further minimises when issues arise.
Comment 1 Pierre Ossman cendio 2022-08-30 10:11:23 CEST
To test this:

1. Connect to a session
2. Switch to a different window locally
3. Switch lock state (e.g. enable caps lock)
4. Switch focus back to the client

At this point, the lock state on the server should immediately change (check for fake key events via xev), but it currently doesn't.

Fake key events are now instead sent when the server detects that something is off. Generally, when you press a letter key.

Note You need to log in before you can comment on or make changes to this bug.